Re: [Qemu-devel] [PATCH v6 03/11] dump: Add API to write vmcore

2014-01-06 Thread Qiao Nuohan
On 01/07/2014 02:12 AM, Laszlo Ersek wrote: @@ -726,6 +726,34 @@ static int write_end_flat_header(int fd) >return 0; >} > > +static int write_buffer(int fd, bool flag_flatten, off_t offset, void *buf, > +size_t size) > +{ You might have wanted to const-qual

Re: [Qemu-devel] [PATCH v6 03/11] dump: Add API to write vmcore

2014-01-06 Thread Laszlo Ersek
On 01/05/14 08:27, Qiao Nuohan wrote: > Function is used to write vmcore. If flag_flatten is specified, flatten format > will be used. In flatten format, data is written block by block in vmcore. > struct MakedumpfileDataHeader is used to indicate the offset and size of a > data > block. > > stru