Re: [Qemu-devel] [PATCH v6] NUMA: Enable adding NUMA node implicitly

2017-11-15 Thread Igor Mammedov
On Tue, 14 Nov 2017 10:34:01 +0800 Dou Liyang wrote: > Linux and Windows need ACPI SRAT table to make memory hotplug work properly, > however currently QEMU doesn't create SRAT table if numa options aren't > present > on CLI. > > Which breaks both linux and windows guests in certain conditions:

Re: [Qemu-devel] [PATCH v6] NUMA: Enable adding NUMA node implicitly

2017-11-15 Thread Igor Mammedov
On Wed, 15 Nov 2017 09:29:22 +0800 Dou Liyang wrote: > Hi Igor, > > [...] > >> +parse_numa_node(ms, &node, NULL); > > I get build break here: > > > > numa.c:451:13: error: too few arguments to function ‘parse_numa_node’ > > parse_numa_node(ms, &node, NULL); > > > >

Re: [Qemu-devel] [PATCH v6] NUMA: Enable adding NUMA node implicitly

2017-11-14 Thread Dou Liyang
Hi Igor, [...] +parse_numa_node(ms, &node, NULL); I get build break here: numa.c:451:13: error: too few arguments to function ‘parse_numa_node’ parse_numa_node(ms, &node, NULL); In upstream tree, your commit cc001888b780 ("numa: fixup parsed NumaNodeOptions earli

Re: [Qemu-devel] [PATCH v6] NUMA: Enable adding NUMA node implicitly

2017-11-14 Thread Igor Mammedov
On Tue, 14 Nov 2017 10:34:01 +0800 Dou Liyang wrote: > Linux and Windows need ACPI SRAT table to make memory hotplug work properly, > however currently QEMU doesn't create SRAT table if numa options aren't > present > on CLI. > > Which breaks both linux and windows guests in certain conditions: