Re: [Qemu-devel] [PATCH v5 7/7] Use qemu_put_buffer_async for guest memory pages

2013-04-05 Thread Kevin Wolf
Am 05.04.2013 um 17:42 hat Paolo Bonzini geschrieben: > Il 05/04/2013 17:39, Kevin Wolf ha scritto: > >> > The solution could be to make bdrv_load_vmstate take an iov/iovcnt pair. > > Ah, so you're saying that instead of linearising the buffer it breaks up > > the requests in tiny pieces? > > Only

Re: [Qemu-devel] [PATCH v5 7/7] Use qemu_put_buffer_async for guest memory pages

2013-04-05 Thread Paolo Bonzini
Il 05/04/2013 17:39, Kevin Wolf ha scritto: >> > The solution could be to make bdrv_load_vmstate take an iov/iovcnt pair. > Ah, so you're saying that instead of linearising the buffer it breaks up > the requests in tiny pieces? Only for RAM (header/page/header/page...), because the page comes stra

Re: [Qemu-devel] [PATCH v5 7/7] Use qemu_put_buffer_async for guest memory pages

2013-04-05 Thread Kevin Wolf
Am 05.04.2013 um 17:23 hat Paolo Bonzini geschrieben: > Il 05/04/2013 15:44, Kevin Wolf ha scritto: > > This seems to have killed savevm performance. I noticed that > > qemu-iotests case 007 took forever on my test box (882 seconds instead > > of something like 10 seconds). It can be reproduced by

Re: [Qemu-devel] [PATCH v5 7/7] Use qemu_put_buffer_async for guest memory pages

2013-04-05 Thread Paolo Bonzini
Il 05/04/2013 15:44, Kevin Wolf ha scritto: > This seems to have killed savevm performance. I noticed that > qemu-iotests case 007 took forever on my test box (882 seconds instead > of something like 10 seconds). It can be reproduced by this script: > > export MALLOC_PERTURB_=11 > qemu-img create

Re: [Qemu-devel] [PATCH v5 7/7] Use qemu_put_buffer_async for guest memory pages

2013-04-05 Thread Kevin Wolf
Am 22.03.2013 um 15:48 hat Orit Wasserman geschrieben: > This will remove an unneeded copy of guest memory pages. > For the page header and device state we still copy the data to the > static buffer the other option is to allocate the memory on demand > which is more expensive. > > Signed-off-by: