Re: [Qemu-devel] [PATCH v5 11/27] raw-posix: Implement .bdrv_lockf

2016-05-27 Thread Fam Zheng
On Tue, 05/24 19:09, Max Reitz wrote: > On 17.05.2016 09:35, Fam Zheng wrote: > > virtlockd in libvirt locks the first byte, we lock byte 1 to avoid > > the intervene. > > > > Both file and host device protocols are covered. > > Is there a reason you didn't cover host_cdrom other than it generall

Re: [Qemu-devel] [PATCH v5 11/27] raw-posix: Implement .bdrv_lockf

2016-05-24 Thread Max Reitz
On 17.05.2016 09:35, Fam Zheng wrote: > virtlockd in libvirt locks the first byte, we lock byte 1 to avoid > the intervene. > > Both file and host device protocols are covered. Is there a reason you didn't cover host_cdrom other than it generally being read-only and thus probably not really needi