Re: [Qemu-devel] [PATCH v5 02/20] qapi.py: add a simple #ifdef conditional

2016-09-07 Thread Eric Blake
On 09/07/2016 08:40 AM, Markus Armbruster wrote: >> Yet another option is to add 'ifdef' keys to the definitions >> themselves, i.e. >> >> { 'command': 'query-gic-capabilities', 'returns': ['GICCapability'], >> 'ifdef': 'TARGET_ARM' } Seems like it might be useful; co

Re: [Qemu-devel] [PATCH v5 02/20] qapi.py: add a simple #ifdef conditional

2016-09-07 Thread Marc-André Lureau
Hi On Wed, Sep 7, 2016 at 5:40 PM Markus Armbruster wrote: > Markus Armbruster writes: > > > Marc-André Lureau writes: > > > >> Hi > >> > >> On Tue, Sep 6, 2016 at 7:58 PM Markus Armbruster > wrote: > >> > >>> QAPI language design issues, copying Eric. > >>> > >>> Marc-André Lureau writes: >

Re: [Qemu-devel] [PATCH v5 02/20] qapi.py: add a simple #ifdef conditional

2016-09-07 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Hi >> >> On Tue, Sep 6, 2016 at 7:58 PM Markus Armbruster wrote: >> >>> QAPI language design issues, copying Eric. >>> >>> Marc-André Lureau writes: >>> >>> > Hi >>> > >>> > On Tue, Sep 6, 2016 at 5:00 PM Markus Armbruster >>> wrote:

Re: [Qemu-devel] [PATCH v5 02/20] qapi.py: add a simple #ifdef conditional

2016-09-07 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Sep 6, 2016 at 7:58 PM Markus Armbruster wrote: > >> QAPI language design issues, copying Eric. >> >> Marc-André Lureau writes: >> >> > Hi >> > >> > On Tue, Sep 6, 2016 at 5:00 PM Markus Armbruster >> wrote: >> > >> >> Marc-André Lureau writes: >> >>

Re: [Qemu-devel] [PATCH v5 02/20] qapi.py: add a simple #ifdef conditional

2016-09-06 Thread Marc-André Lureau
Hi On Tue, Sep 6, 2016 at 7:58 PM Markus Armbruster wrote: > QAPI language design issues, copying Eric. > > Marc-André Lureau writes: > > > Hi > > > > On Tue, Sep 6, 2016 at 5:00 PM Markus Armbruster > wrote: > > > >> Marc-André Lureau writes: > >> > >> > Learn to parse #define files provided

Re: [Qemu-devel] [PATCH v5 02/20] qapi.py: add a simple #ifdef conditional

2016-09-06 Thread Markus Armbruster
QAPI language design issues, copying Eric. Marc-André Lureau writes: > Hi > > On Tue, Sep 6, 2016 at 5:00 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> > Learn to parse #define files provided with -f option, and skip >> > undefined #ifdef blocks in the schema. >> > >> > This

Re: [Qemu-devel] [PATCH v5 02/20] qapi.py: add a simple #ifdef conditional

2016-09-06 Thread Marc-André Lureau
Hi On Tue, Sep 6, 2016 at 5:00 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Learn to parse #define files provided with -f option, and skip > > undefined #ifdef blocks in the schema. > > > > This is a very simple pre-processing, without stacking support or > > evaluation (it cou

Re: [Qemu-devel] [PATCH v5 02/20] qapi.py: add a simple #ifdef conditional

2016-09-06 Thread Markus Armbruster
Marc-André Lureau writes: > Learn to parse #define files provided with -f option, and skip > undefined #ifdef blocks in the schema. > > This is a very simple pre-processing, without stacking support or > evaluation (it could be implemented if needed). > > Signed-off-by: Marc-André Lureau > --- >