Re: [Qemu-devel] [PATCH v5 02/11] ARM: exynos4210: UART support

2012-01-10 Thread Evgeny Voevodin
On 01/10/2012 04:11 PM, Peter Maydell wrote: +case UINTP: +s->reg[I_(UINTP)]&= ~val; +/* XXX: It's the assumption that it works in this way */ Can you expand this comment a little to clarify exactly what the assumption you're making is? It was not clear from documentation if

Re: [Qemu-devel] [PATCH v5 02/11] ARM: exynos4210: UART support

2012-01-10 Thread Peter Maydell
On 23 December 2011 11:40, Evgeny Voevodin wrote: > From: Maksim Kozlov > > Add basic support of exynos4210 UART > > Signed-off-by: Evgeny Voevodin > --- >  Makefile.target      |    2 +- >  hw/exynos4210.c      |   24 ++ >  hw/exynos4210.h      |    9 + >  hw/exynos4210_uart.c |  670 > +++