Re: [Qemu-devel] [PATCH v4 5/9] target-avr: adding AVR interrupt handling

2016-06-06 Thread Peter Maydell
On 6 June 2016 at 22:44, Richard Henderson wrote: > On 06/06/2016 03:37 AM, Michael Rolnik wrote: >> >> +if (avr_feature(env, AVR_FEATURE_3_BYTE_PC)) { >> +stb_phys(cs->as, env->sp--, (ret & 0xff)); >> +stb_phys(cs->as, env->sp--, (ret & 0x00ff00) >> 8); >> +stb_ph

Re: [Qemu-devel] [PATCH v4 5/9] target-avr: adding AVR interrupt handling

2016-06-06 Thread Richard Henderson
On 06/06/2016 03:37 AM, Michael Rolnik wrote: +if (avr_feature(env, AVR_FEATURE_3_BYTE_PC)) { +stb_phys(cs->as, env->sp--, (ret & 0xff)); +stb_phys(cs->as, env->sp--, (ret & 0x00ff00) >> 8); +stb_phys(cs->as, env->sp--, (ret & 0xff) >> 16); +} else if (avr