Re: [Qemu-devel] [PATCH v4 42/64] tcg/arm: Handle ctz and clz opcodes

2016-12-08 Thread Richard Henderson
On 12/08/2016 09:56 AM, Alex Bennée wrote: +if (c && a2 == 32) { +tcg_out_dat_reg(s, COND_AL, INSN_CLZ, a0, 0, a1, 0); +break; +} Why the early break instead of else leg? +tcg_out_dat_imm(s, COND_AL, ARITH_CMP, 0, a1, 0); +tcg_out_dat_re

Re: [Qemu-devel] [PATCH v4 42/64] tcg/arm: Handle ctz and clz opcodes

2016-12-08 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.h | 4 ++-- > tcg/arm/tcg-target.inc.c | 27 +++ > 2 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/tcg/arm/tcg-target.h b/tcg/arm/tcg-target.h > index 02cc242