Re: [Qemu-devel] [PATCH v4 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-04-30 Thread Don Slutz
On 04/30/15 09:55, Paolo Bonzini wrote: > > > On 30/04/2015 15:32, Don Slutz wrote: >> +#ifdef VMPORT_SHORT >> +info->value->key = g_strdup(ckey); >> +#else >> +info->value->key = g_strdup_printf("guestinfo.%s", ckey); >> +#endif > > What is VMPORT_SHORT for? > Simpler code. Looks lik

Re: [Qemu-devel] [PATCH v4 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 15:32, Don Slutz wrote: > +#ifdef VMPORT_SHORT > +info->value->key = g_strdup(ckey); > +#else > +info->value->key = g_strdup_printf("guestinfo.%s", ckey); > +#endif What is VMPORT_SHORT for? Paolo