Re: [Qemu-devel] [PATCH v4 37/38] raw: Convert a warning to warn_report()

2018-10-19 Thread Markus Armbruster
I'm dropping this patch for now. Nice formatting of hints is good. Consistency is good. The way to get both is probably a more structured interface to print hints after FOO_report(). But this goes beyond what this series tries to do.

Re: [Qemu-devel] [PATCH v4 37/38] raw: Convert a warning to warn_report()

2018-10-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.10.2018 um 10:27 hat Markus Armbruster geschrieben: >> Convert the warning about dangerous automatic probing of raw images to >> warn_report(). Split its text to conform to conventions spelled out >> in warn_report()'s contract. > > One of the things the warn_report()

Re: [Qemu-devel] [PATCH v4 37/38] raw: Convert a warning to warn_report()

2018-10-17 Thread Kevin Wolf
Am 17.10.2018 um 10:27 hat Markus Armbruster geschrieben: > Convert the warning about dangerous automatic probing of raw images to > warn_report(). Split its text to conform to conventions spelled out > in warn_report()'s contract. One of the things the warn_report() documentation says is: I