Re: [Qemu-devel] [PATCH v4 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-04 Thread Blue Swirl
On Sat, Aug 4, 2012 at 2:44 AM, Bharata B Rao wrote: > On Fri, Aug 03, 2012 at 03:57:20PM +, Blue Swirl wrote: >> >> > +static void gluster_finish_aiocb(struct glfs_fd *fd, ssize_t ret, void >> >> > *arg) >> >> > +{ >> >> > +GlusterAIOCB *acb = (GlusterAIOCB *)arg; >> >> > +BDRVGluste

Re: [Qemu-devel] [PATCH v4 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-03 Thread Bharata B Rao
On Fri, Aug 03, 2012 at 03:57:20PM +, Blue Swirl wrote: > >> > +static void gluster_finish_aiocb(struct glfs_fd *fd, ssize_t ret, void > >> > *arg) > >> > +{ > >> > +GlusterAIOCB *acb = (GlusterAIOCB *)arg; > >> > +BDRVGlusterState *s = acb->common.bs->opaque; > >> > + > >> > +acb-

Re: [Qemu-devel] [PATCH v4 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-03 Thread Blue Swirl
On Thu, Aug 2, 2012 at 3:55 AM, Bharata B Rao wrote: > On Wed, Aug 01, 2012 at 06:35:22PM +, Blue Swirl wrote: >> > + >> > +if (!transport) { >> > +uri->transport = strdup("socket"); >> >> g_strdup > > Sorry about that, pitfalls of developing the parsing code out of line :( > >> >

Re: [Qemu-devel] [PATCH v4 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-01 Thread Bharata B Rao
On Wed, Aug 01, 2012 at 06:35:22PM +, Blue Swirl wrote: > > + > > +if (!transport) { > > +uri->transport = strdup("socket"); > > g_strdup Sorry about that, pitfalls of developing the parsing code out of line :( > > +static int qemu_gluster_parseuri(GlusterURI *uri, const char *fi

Re: [Qemu-devel] [PATCH v4 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-01 Thread Blue Swirl
On Wed, Aug 1, 2012 at 2:16 PM, Bharata B Rao wrote: > block: Support GlusterFS as a QEMU block backend. > > From: Bharata B Rao > > This patch adds gluster as the new block backend in QEMU. This gives > QEMU the ability to boot VM images from gluster volumes. Its already > possible to boot from