Re: [Qemu-devel] [PATCH v4 17/22] libqtest: Add qmp_args() helper

2017-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/09/2017 10:57 AM, Markus Armbruster wrote: > >> I don't like the qmp_args name. It's not about arguments, it's about >> sending a command with arguments. >> >> I'm afraid I'm getting pretty thorougly confused by the evolving >> interface. So I stop and think how it s

Re: [Qemu-devel] [PATCH v4 17/22] libqtest: Add qmp_args() helper

2017-08-09 Thread Eric Blake
On 08/09/2017 10:57 AM, Markus Armbruster wrote: > I don't like the qmp_args name. It's not about arguments, it's about > sending a command with arguments. > > I'm afraid I'm getting pretty thorougly confused by the evolving > interface. So I stop and think how it should look like when done. A

Re: [Qemu-devel] [PATCH v4 17/22] libqtest: Add qmp_args() helper

2017-08-09 Thread Markus Armbruster
Eric Blake writes: > Similar to the previous helper, we can reduce the boilerplate > of most callers by passing the command name separately from > the interpolated arguments. Adjust the majority of the callers > that can use the new helpers; in the process, fixing a few > places where we would h