Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-11 Thread Zhi Yong Wu
On Tue, Jun 12, 2012 at 4:05 AM, Luiz Capitulino wrote: > On Mon, 11 Jun 2012 22:15:55 +0800 > Zhi Yong Wu wrote: > >> On Mon, Jun 11, 2012 at 2:28 PM, Paolo Bonzini wrote: >> > Il 09/06/2012 05:04, Zhi Yong Wu ha scritto: >> > This commit looks suspicious because it removes a user-visible q

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-11 Thread Zhi Yong Wu
On Mon, Jun 11, 2012 at 10:42 PM, Stefan Hajnoczi wrote: > On Mon, Jun 11, 2012 at 3:24 PM, Zhi Yong Wu wrote: >> On Mon, Jun 11, 2012 at 4:57 PM, Stefan Hajnoczi >> wrote: >>> On Mon, Jun 11, 2012 at 08:28:57AM +0200, Paolo Bonzini wrote: Il 09/06/2012 05:04, Zhi Yong Wu ha scritto: >

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-11 Thread Anthony Liguori
On 06/11/2012 01:28 AM, Paolo Bonzini wrote: Il 09/06/2012 05:04, Zhi Yong Wu ha scritto: This commit looks suspicious because it removes a user-visible qdev property but we're trying to preserve backward compatibility. This command-line will break: x86_64-softmmu/qemu-system-x86_64 -net user,

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-11 Thread Luiz Capitulino
On Mon, 11 Jun 2012 22:15:55 +0800 Zhi Yong Wu wrote: > On Mon, Jun 11, 2012 at 2:28 PM, Paolo Bonzini wrote: > > Il 09/06/2012 05:04, Zhi Yong Wu ha scritto: > > This commit looks suspicious because it removes a user-visible qdev > > property but we're trying to preserve backward compat

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-11 Thread Stefan Hajnoczi
On Mon, Jun 11, 2012 at 3:24 PM, Zhi Yong Wu wrote: > On Mon, Jun 11, 2012 at 4:57 PM, Stefan Hajnoczi > wrote: >> On Mon, Jun 11, 2012 at 08:28:57AM +0200, Paolo Bonzini wrote: >>> Il 09/06/2012 05:04, Zhi Yong Wu ha scritto: >>> This commit looks suspicious because it removes a user-visibl

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-11 Thread Zhi Yong Wu
On Mon, Jun 11, 2012 at 4:57 PM, Stefan Hajnoczi wrote: > On Mon, Jun 11, 2012 at 08:28:57AM +0200, Paolo Bonzini wrote: >> Il 09/06/2012 05:04, Zhi Yong Wu ha scritto: >> This commit looks suspicious because it removes a user-visible qdev >> property but we're trying to preserve backwar

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-11 Thread Zhi Yong Wu
On Mon, Jun 11, 2012 at 2:28 PM, Paolo Bonzini wrote: > Il 09/06/2012 05:04, Zhi Yong Wu ha scritto: > This commit looks suspicious because it removes a user-visible qdev > property but we're trying to preserve backward compatibility.  This > command-line will break: > > x86_64

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-11 Thread Stefan Hajnoczi
On Mon, Jun 11, 2012 at 08:28:57AM +0200, Paolo Bonzini wrote: > Il 09/06/2012 05:04, Zhi Yong Wu ha scritto: > This commit looks suspicious because it removes a user-visible qdev > property but we're trying to preserve backward compatibility. This > command-line will break: >

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-10 Thread Paolo Bonzini
Il 09/06/2012 05:04, Zhi Yong Wu ha scritto: This commit looks suspicious because it removes a user-visible qdev property but we're trying to preserve backward compatibility. This command-line will break: x86_64-softmmu/qemu-system-x86_64 -net user,vlan=1 -device vir

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-08 Thread Zhi Yong Wu
On Sat, Jun 9, 2012 at 12:09 AM, Stefan Hajnoczi wrote: > On Fri, Jun 8, 2012 at 3:48 PM, Zhi Yong Wu wrote: >> On Fri, Jun 8, 2012 at 9:23 PM, Stefan Hajnoczi wrote: >>> On Mon, Jun 4, 2012 at 6:29 AM,   wrote: From: Stefan Hajnoczi The vlan feature is implemented using hubs and

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-08 Thread Stefan Hajnoczi
On Fri, Jun 8, 2012 at 3:48 PM, Zhi Yong Wu wrote: > On Fri, Jun 8, 2012 at 9:23 PM, Stefan Hajnoczi wrote: >> On Mon, Jun 4, 2012 at 6:29 AM,   wrote: >>> From: Stefan Hajnoczi >>> >>> The vlan feature is implemented using hubs and no longer uses >>> special-purpose VLANState structs that are a

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-08 Thread Zhi Yong Wu
On Fri, Jun 8, 2012 at 9:23 PM, Stefan Hajnoczi wrote: > On Mon, Jun 4, 2012 at 6:29 AM,   wrote: >> From: Stefan Hajnoczi >> >> The vlan feature is implemented using hubs and no longer uses >> special-purpose VLANState structs that are accessible as qdev >> properties. >> >> Signed-off-by: Stefa

Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-08 Thread Stefan Hajnoczi
On Mon, Jun 4, 2012 at 6:29 AM, wrote: > From: Stefan Hajnoczi > > The vlan feature is implemented using hubs and no longer uses > special-purpose VLANState structs that are accessible as qdev > properties. > > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Zhi Yong Wu > --- >  hw/qdev-proper