Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

2019-06-10 Thread Juan Quintela
Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:41PM +0200, Juan Quintela wrote: >>diff --git a/qapi/migration.json b/qapi/migration.json >>index 9cfbaf8c6c..8ec1944b7a 100644 >>--- a/qapi/migration.json >>+++ b/qapi/migration.json >>@@ -482,6 +482,19 @@ >> # TODO either fuse back into MigrationPa

Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

2019-06-10 Thread Juan Quintela
Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:41PM +0200, Juan Quintela wrote: >>Signed-off-by: Juan Quintela >>@@ -1821,6 +1826,18 @@ void hmp_migrate_set_parameter(Monitor *mon, const >>QDict *qdict) >> p->has_multifd_channels = true; >> visit_type_int(v, param, &p->multifd_c

Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

2019-06-10 Thread Juan Quintela
Wei Yang wrote: > On Wed, May 15, 2019 at 02:15:41PM +0200, Juan Quintela wrote: >>Signed-off-by: Juan Quintela >>diff --git a/tests/migration-test.c b/tests/migration-test.c >>index 65d5e256a7..8a1ccc2516 100644 >>--- a/tests/migration-test.c >>+++ b/tests/migration-test.c > > Well, may I sugges

Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

2019-06-10 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: >> +case MIGRATION_PARAMETER_MULTIFD_COMPRESS: >> +p->has_multifd_compress = true; >> +visit_type_MultifdCompress(v, param, &compress_type, &err); >> +if (err) { >> +break; >> +} >> +if (compr

Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

2019-05-20 Thread Wei Yang
On Wed, May 15, 2019 at 02:15:41PM +0200, Juan Quintela wrote: >diff --git a/qapi/migration.json b/qapi/migration.json >index 9cfbaf8c6c..8ec1944b7a 100644 >--- a/qapi/migration.json >+++ b/qapi/migration.json >@@ -482,6 +482,19 @@ > ## > { 'command': 'query-migrate-capabilities', 'returns': > [

Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

2019-05-20 Thread Wei Yang
On Wed, May 15, 2019 at 02:15:41PM +0200, Juan Quintela wrote: >Signed-off-by: Juan Quintela > >--- >Rename it to NONE >Fix typos (dave) >--- > hmp.c| 17 + > hw/core/qdev-properties.c| 13 + > include/hw/qdev-properties.h | 1 + > migration/mi

Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

2019-05-20 Thread Wei Yang
On Wed, May 15, 2019 at 02:15:41PM +0200, Juan Quintela wrote: >Signed-off-by: Juan Quintela > >--- >Rename it to NONE >Fix typos (dave) >--- > hmp.c| 17 + > hw/core/qdev-properties.c| 13 + > include/hw/qdev-properties.h | 1 + > migration/mi

Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter

2019-05-15 Thread Markus Armbruster
Juan Quintela writes: > Signed-off-by: Juan Quintela > > --- > Rename it to NONE > Fix typos (dave) > --- > hmp.c| 17 + > hw/core/qdev-properties.c| 13 + > include/hw/qdev-properties.h | 1 + > migration/migration.c| 16