Re: [Qemu-devel] [PATCH v3 35/43] tcg: dynamically allocate optimizer temps

2017-07-20 Thread Emilio G. Cota
On Thu, Jul 20, 2017 at 14:02:53 -1000, Richard Henderson wrote: > On 07/20/2017 01:53 PM, Emilio G. Cota wrote: > >BTW, is there any chance that the pool will be initialized before we copy > >tcg_init_ctx? That'd mean the main thread has performed translation, which > >seems unlikely to me. But sh

Re: [Qemu-devel] [PATCH v3 35/43] tcg: dynamically allocate optimizer temps

2017-07-20 Thread Richard Henderson
On 07/20/2017 01:53 PM, Emilio G. Cota wrote: BTW, is there any chance that the pool will be initialized before we copy tcg_init_ctx? That'd mean the main thread has performed translation, which seems unlikely to me. But should then we bother clearing the TCGProfile counters after we copy tcg_ini

Re: [Qemu-devel] [PATCH v3 35/43] tcg: dynamically allocate optimizer temps

2017-07-20 Thread Emilio G. Cota
On Wed, Jul 19, 2017 at 21:39:35 -1000, Richard Henderson wrote: > On 07/19/2017 05:09 PM, Emilio G. Cota wrote: > >Groundwork for supporting multiple TCG contexts. > >That is, 2.70% slowdown. > > That's disappointing. How about using tcg_malloc? > > Maximum allocation is sizeof(tcg_temp_info) *

Re: [Qemu-devel] [PATCH v3 35/43] tcg: dynamically allocate optimizer temps

2017-07-20 Thread Richard Henderson
On 07/19/2017 05:09 PM, Emilio G. Cota wrote: Groundwork for supporting multiple TCG contexts. While at it, also allocate temps_used directly as a bitmap of the required size, instead of having a bitmap of TCG_MAX_TEMPS via TCGTempSet. Performance-wise we lose about 2% in a translation-heavy wo