Re: [Qemu-devel] [PATCH v3 3/4] savevm: define new unambiguous migration format

2011-08-12 Thread Paolo Bonzini
On 08/12/2011 05:16 PM, Anthony Liguori wrote: Because of the change we made for 0.15, this is no longer strictly needed. It only matters if we add a subsection to a structure, right? Yes. We can also check the current migration format in the "needed" function for such subsections, if necess

Re: [Qemu-devel] [PATCH v3 3/4] savevm: define new unambiguous migration format

2011-08-12 Thread Anthony Liguori
On 08/12/2011 10:11 AM, Anthony Liguori wrote: On 08/12/2011 04:59 AM, Paolo Bonzini wrote: With the current migration format, VMS_STRUCTs with subsections are ambiguous. The protocol cannot tell whether a 0x5 byte after the VMS_STRUCT is a subsection or part of the parent data stream. In the pa

Re: [Qemu-devel] [PATCH v3 3/4] savevm: define new unambiguous migration format

2011-08-12 Thread Anthony Liguori
On 08/12/2011 04:59 AM, Paolo Bonzini wrote: With the current migration format, VMS_STRUCTs with subsections are ambiguous. The protocol cannot tell whether a 0x5 byte after the VMS_STRUCT is a subsection or part of the parent data stream. In the past QEMU assumed it was always a part of a subse