Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-22 Thread Igor Mammedov
On Thu, 21 Jun 2018 19:10:38 +0200 Marc-André Lureau wrote: > Hi > > On Thu, Jun 21, 2018 at 4:23 PM, Igor Mammedov wrote: > > On Thu, 21 Jun 2018 15:21:02 +0200 > > Marc-André Lureau wrote: > > > >> Hi > >> > >> On Thu, Jun 21, 2018 at 2:54 PM, Igor Mammedov > >> wrote: > >> > On Tue, 1

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-21 Thread Stefan Berger
On 06/21/2018 01:10 PM, Marc-André Lureau wrote: Hi On Thu, Jun 21, 2018 at 4:23 PM, Igor Mammedov wrote: On Thu, 21 Jun 2018 15:21:02 +0200 Marc-André Lureau wrote: Hi On Thu, Jun 21, 2018 at 2:54 PM, Igor Mammedov wrote: On Tue, 15 May 2018 14:14:32 +0200 Marc-André Lureau wrote: Fr

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-21 Thread Marc-André Lureau
Hi On Thu, Jun 21, 2018 at 4:23 PM, Igor Mammedov wrote: > On Thu, 21 Jun 2018 15:21:02 +0200 > Marc-André Lureau wrote: > >> Hi >> >> On Thu, Jun 21, 2018 at 2:54 PM, Igor Mammedov wrote: >> > On Tue, 15 May 2018 14:14:32 +0200 >> > Marc-André Lureau wrote: >> > >> >> From: Stefan Berger >>

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-21 Thread Igor Mammedov
On Thu, 21 Jun 2018 16:13:32 +0200 Marc-André Lureau wrote: > Hi > > On Thu, Jun 21, 2018 at 3:22 PM, Marc-André Lureau > wrote: > > Hi > > > > On Thu, Jun 21, 2018 at 3:21 PM, Marc-André Lureau > > wrote: > > > +method = aml_method("TPFN", 1, AML_SERIALIZED); > >>> not quite sure

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-21 Thread Igor Mammedov
On Thu, 21 Jun 2018 15:21:02 +0200 Marc-André Lureau wrote: > Hi > > On Thu, Jun 21, 2018 at 2:54 PM, Igor Mammedov wrote: > > On Tue, 15 May 2018 14:14:32 +0200 > > Marc-André Lureau wrote: > > > >> From: Stefan Berger > >> > >> The TPM Physical Presence interface consists of an ACPI part,

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-21 Thread Marc-André Lureau
Hi On Thu, Jun 21, 2018 at 3:22 PM, Marc-André Lureau wrote: > Hi > > On Thu, Jun 21, 2018 at 3:21 PM, Marc-André Lureau > wrote: > +method = aml_method("TPFN", 1, AML_SERIALIZED); >>> not quite sure how this method (supposed to ) work(s), >>> it could use nice comment explaining mechan

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-21 Thread Stefan Berger
On 06/21/2018 09:21 AM, Marc-André Lureau wrote: Hi On Thu, Jun 21, 2018 at 2:54 PM, Igor Mammedov wrote: On Tue, 15 May 2018 14:14:32 +0200 Marc-André Lureau wrote: From: Stefan Berger The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the fir

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-21 Thread Marc-André Lureau
Hi On Thu, Jun 21, 2018 at 3:21 PM, Marc-André Lureau wrote: >>> +method = aml_method("TPFN", 1, AML_SERIALIZED); >> not quite sure how this method (supposed to ) work(s), >> it could use nice comment explaining mechanics. >> > > Windows doesn't like DerefOf (FUNC [N]), it returned wrong val

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-21 Thread Marc-André Lureau
Hi On Thu, Jun 21, 2018 at 2:54 PM, Igor Mammedov wrote: > On Tue, 15 May 2018 14:14:32 +0200 > Marc-André Lureau wrote: > >> From: Stefan Berger >> >> The TPM Physical Presence interface consists of an ACPI part, a shared >> memory part, and code in the firmware. Users can send messages to the

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-21 Thread Igor Mammedov
On Tue, 15 May 2018 14:14:32 +0200 Marc-André Lureau wrote: > From: Stefan Berger > > The TPM Physical Presence interface consists of an ACPI part, a shared > memory part, and code in the firmware. Users can send messages to the > firmware by writing a code into the shared memory through invoki

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-20 Thread Stefan Berger
On 06/20/2018 10:35 AM, Marc-André Lureau wrote: Hi On Wed, Jun 20, 2018 at 4:08 PM, Michael S. Tsirkin wrote: On Tue, May 15, 2018 at 02:14:32PM +0200, Marc-André Lureau wrote: From: Stefan Berger The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-20 Thread Michael S. Tsirkin
On Wed, Jun 20, 2018 at 04:35:23PM +0200, Marc-André Lureau wrote: > Hi > > On Wed, Jun 20, 2018 at 4:08 PM, Michael S. Tsirkin wrote: > > On Tue, May 15, 2018 at 02:14:32PM +0200, Marc-André Lureau wrote: > >> From: Stefan Berger > >> > >> The TPM Physical Presence interface consists of an ACPI

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-20 Thread Laszlo Ersek
On 06/20/18 16:35, Marc-André Lureau wrote: > Hi > > On Wed, Jun 20, 2018 at 4:08 PM, Michael S. Tsirkin wrote: >> On Tue, May 15, 2018 at 02:14:32PM +0200, Marc-André Lureau wrote: >>> From: Stefan Berger >>> >>> The TPM Physical Presence interface consists of an ACPI part, a shared >>> memory

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-20 Thread Marc-André Lureau
Hi On Wed, Jun 20, 2018 at 4:08 PM, Michael S. Tsirkin wrote: > On Tue, May 15, 2018 at 02:14:32PM +0200, Marc-André Lureau wrote: >> From: Stefan Berger >> >> The TPM Physical Presence interface consists of an ACPI part, a shared >> memory part, and code in the firmware. Users can send messages

Re: [Qemu-devel] [PATCH v3 3/4] acpi: build TPM Physical Presence interface

2018-06-20 Thread Michael S. Tsirkin
On Tue, May 15, 2018 at 02:14:32PM +0200, Marc-André Lureau wrote: > From: Stefan Berger > > The TPM Physical Presence interface consists of an ACPI part, a shared > memory part, and code in the firmware. Users can send messages to the > firmware by writing a code into the shared memory through i