Re: [Qemu-devel] [PATCH v3 2/6] monitor: flush qmp responses when CLOSED

2018-06-19 Thread Markus Armbruster
Peter Xu writes: > On Fri, Jun 15, 2018 at 10:11:34AM +0200, Markus Armbruster wrote: [...] >> diff --git a/monitor.c b/monitor.c >> index e59d4f09ac..af28977549 100644 >> --- a/monitor.c >> +++ b/monitor.c >> @@ -512,7 +512,7 @@ struct QMPResponse { >> }; >> typedef struct QMPResponse QMPRespo

Re: [Qemu-devel] [PATCH v3 2/6] monitor: flush qmp responses when CLOSED

2018-06-18 Thread Peter Xu
On Fri, Jun 15, 2018 at 10:11:34AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Previously we clean up the queues when we got CLOSED event. It was used > > to make sure we won't send leftover replies/events of a old client to a > > new client. Now this patch does an extra operation

Re: [Qemu-devel] [PATCH v3 2/6] monitor: flush qmp responses when CLOSED

2018-06-15 Thread Markus Armbruster
Peter Xu writes: > Previously we clean up the queues when we got CLOSED event. It was used > to make sure we won't send leftover replies/events of a old client to a > new client. Now this patch does an extra operation to flush the > response queue before cleaning up. > > In most cases, a QMP se