Re: [Qemu-devel] [PATCH v3 2/5] Extract some reusable vGIC code

2015-07-14 Thread Pavel Fedin
Hi! > /local/augere/LINARO/QEMU/qemu/hw/intc/arm_gic_kvm.c:565:5: error: > passing argument 2 of 'qdev_init_gpio_in' from incompatible pointer type > [-Werror] > qdev_init_gpio_in(dev, kvm_arm_gic_set_irq, i); > > also > > /local/augere/LINARO/QEMU/qemu/hw/intc/arm_gic_kvm.c:90:13: error:

Re: [Qemu-devel] [PATCH v3 2/5] Extract some reusable vGIC code

2015-07-09 Thread Eric Auger
Pavel, On 07/07/2015 03:54 PM, Pavel Fedin wrote: > These functions are useful also for vGICv3 implementation. Make them > accessible > from within other modules. > > Actually kvm_dist_get() and kvm_dist_put() could also be made reusable, but > they would require two extra parameters (s->dev_fd a