Re: [Qemu-devel] [PATCH v3 18/39] target/mips: Use env_cpu, env_archcpu

2019-05-15 Thread Aleksandar Markovic
On May 8, 2019 4:33 PM, "Richard Henderson" wrote: > > On 5/8/19 1:15 AM, Aleksandar Markovic wrote: > > > > On May 8, 2019 2:19 AM, "Richard Henderson" < richard.hender...@linaro.org > > > wrote: > >> > >> > >> > > > > This commit message doesnˊt explain the r

Re: [Qemu-devel] [PATCH v3 18/39] target/mips: Use env_cpu, env_archcpu

2019-05-11 Thread Aleksandar Markovic
On May 8, 2019 4:33 PM, "Richard Henderson" wrote: > > On 5/8/19 1:15 AM, Aleksandar Markovic wrote: > > > > On May 8, 2019 2:19 AM, "Richard Henderson" < richard.hender...@linaro.org > > > wrote: > >> > >> > >> > > > > This commit message doesnˊt explain the r

Re: [Qemu-devel] [PATCH v3 18/39] target/mips: Use env_cpu, env_archcpu

2019-05-09 Thread Aleksandar Markovic
On May 8, 2019 11:53 PM, "Philippe Mathieu-Daudé" wrote: > > Hi Richard, Aleksandar. > > On 5/8/19 4:32 PM, Richard Henderson wrote: > > On 5/8/19 1:15 AM, Aleksandar Markovic wrote: > >> > >> On May 8, 2019 2:19 AM, "Richard Henderson" < richard.hender...@linaro.org > >>

Re: [Qemu-devel] [PATCH v3 18/39] target/mips: Use env_cpu, env_archcpu

2019-05-08 Thread Philippe Mathieu-Daudé
Hi Richard, Aleksandar. On 5/8/19 4:32 PM, Richard Henderson wrote: > On 5/8/19 1:15 AM, Aleksandar Markovic wrote: >> >> On May 8, 2019 2:19 AM, "Richard Henderson" > > wrote: >>> >>> >>> >> >> This commit message doesnˊt explain the reason for the change, and

Re: [Qemu-devel] [PATCH v3 18/39] target/mips: Use env_cpu, env_archcpu

2019-05-08 Thread Richard Henderson
On 5/8/19 1:15 AM, Aleksandar Markovic wrote: > > On May 8, 2019 2:19 AM, "Richard Henderson" > wrote: >> >> >> > > This commit message doesnˊt explain the reason for the change, and why is this > an improvement. The underlyng reason for distingishing between

Re: [Qemu-devel] [PATCH v3 18/39] target/mips: Use env_cpu, env_archcpu

2019-05-08 Thread Aleksandar Markovic
On May 8, 2019 2:19 AM, "Richard Henderson" wrote: > > > This commit message doesnˊt explain the reason for the change, and why is this an improvement. The underlyng reason for distingishing between env_cpu and env_archcpu cases is not explained too. Thanks, Aleksandar > Reviewed-by: Philippe M