Re: [Qemu-devel] [PATCH v3 10/10] block: Allow changing 'force-share' on reopen

2018-09-27 Thread Kevin Wolf
Am 26.09.2018 um 13:39 hat Alberto Garcia geschrieben: > On Wed 26 Sep 2018 01:34:28 PM CEST, Kevin Wolf wrote: > >> @@ -3353,6 +3370,7 @@ void bdrv_reopen_commit(BDRVReopenState > >> *reopen_state) > >> bs->open_flags = reopen_state->flags; > >> bs->read_only = !(reopen_state->f

Re: [Qemu-devel] [PATCH v3 10/10] block: Allow changing 'force-share' on reopen

2018-09-26 Thread Alberto Garcia
On Wed 26 Sep 2018 01:34:28 PM CEST, Kevin Wolf wrote: >> @@ -3353,6 +3370,7 @@ void bdrv_reopen_commit(BDRVReopenState *reopen_state) >> bs->open_flags = reopen_state->flags; >> bs->read_only = !(reopen_state->flags & BDRV_O_RDWR); >> bs->detect_zeroes = reopen_state->d

Re: [Qemu-devel] [PATCH v3 10/10] block: Allow changing 'force-share' on reopen

2018-09-26 Thread Kevin Wolf
Am 06.09.2018 um 11:37 hat Alberto Garcia geschrieben: > 'force-share' is one of the basic BlockdevOptions available for all > drivers, but it's not handled by bdrv_reopen_prepare() so any attempt > to change it results in a "Cannot change the option" error: > >(qemu) qemu-io virtio0 "reopen -