Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-09 Thread Gleb Natapov
On Thu, Feb 09, 2012 at 05:00:52PM +0100, Gerd Hoffmann wrote: > Hi, > > > I'll try to get a complete v4 out of the door later today, that should > > the direction I'm heading to more clear than these incremental bits. > > While wading through the acpi mess^Wcode: the acpi timer can s3 wakeups

Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-09 Thread Gerd Hoffmann
Hi, > I'll try to get a complete v4 out of the door later today, that should > the direction I'm heading to more clear than these incremental bits. While wading through the acpi mess^Wcode: the acpi timer can s3 wakeups too IIRC, is that correct? cheers, Gerd

Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-09 Thread Gerd Hoffmann
Hi, >>> We need to give ACPI ability to prevent wakeup. So, for instance, if RTC >>> alarm calls wakeup but ACPI detects that RTC_EN is cleared it can >>> prevent it. >> >> Yea, already figured that after reading your rtc reply ... >> >> One more incremental attached for review. >> > We can star

Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-09 Thread Gleb Natapov
On Thu, Feb 09, 2012 at 01:46:07PM +0100, Gerd Hoffmann wrote: > Hi, > > >> Incremental patch (just infrastructure, no acpi windup yet) attached. > >> Something like this? > >> > > We need to give ACPI ability to prevent wakeup. So, for instance, if RTC > > alarm calls wakeup but ACPI detects th

Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-09 Thread Gerd Hoffmann
Hi, >> Incremental patch (just infrastructure, no acpi windup yet) attached. >> Something like this? >> > We need to give ACPI ability to prevent wakeup. So, for instance, if RTC > alarm calls wakeup but ACPI detects that RTC_EN is cleared it can > prevent it. Yea, already figured that after re

Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-09 Thread Gleb Natapov
On Thu, Feb 09, 2012 at 01:02:47PM +0100, Gerd Hoffmann wrote: > On 02/09/12 12:19, Gleb Natapov wrote: > > On Thu, Feb 09, 2012 at 11:45:21AM +0100, Gerd Hoffmann wrote: > >> On 02/09/12 09:48, Gleb Natapov wrote: > >>> On Wed, Feb 08, 2012 at 12:00:14PM +0100, Gerd Hoffmann wrote: > * qemu_

Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-09 Thread Gerd Hoffmann
On 02/09/12 12:19, Gleb Natapov wrote: > On Thu, Feb 09, 2012 at 11:45:21AM +0100, Gerd Hoffmann wrote: >> On 02/09/12 09:48, Gleb Natapov wrote: >>> On Wed, Feb 08, 2012 at 12:00:14PM +0100, Gerd Hoffmann wrote: * qemu_system_wakeup_request is supposed to be called on events which sh

Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-09 Thread Gleb Natapov
On Thu, Feb 09, 2012 at 11:45:21AM +0100, Gerd Hoffmann wrote: > On 02/09/12 09:48, Gleb Natapov wrote: > > On Wed, Feb 08, 2012 at 12:00:14PM +0100, Gerd Hoffmann wrote: > >> * qemu_system_wakeup_request is supposed to be called on events which > >>should wake up the guest. > >> > > qemu_syst

Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-09 Thread Gerd Hoffmann
On 02/09/12 09:48, Gleb Natapov wrote: > On Wed, Feb 08, 2012 at 12:00:14PM +0100, Gerd Hoffmann wrote: >> * qemu_system_wakeup_request is supposed to be called on events which >>should wake up the guest. >> > qemu_system_wakeup_request() should get wakeup source as a parameter. > There are wa

Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-09 Thread Gleb Natapov
On Wed, Feb 08, 2012 at 12:00:14PM +0100, Gerd Hoffmann wrote: > This patch adds some infrastructure to handle suspend and resume to > qemu. First there are two functions to switch state and second there > is a suspend notifier: > > * qemu_system_suspend_request() is supposed to be called when t