Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus Resettable

2019-08-12 Thread David Gibson
On Wed, Aug 07, 2019 at 09:55:13AM +0200, Damien Hedde wrote: > > > On 8/6/19 2:35 AM, David Gibson wrote: > > On Wed, Jul 31, 2019 at 11:09:05AM +0200, Damien Hedde wrote: > >> > >> > >> On 7/31/19 7:56 AM, David Gibson wrote: > >>> On Mon, Jul 29, 2019 at 04:56:25PM +0200, Damien Hedde wrote: >

Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus Resettable

2019-08-12 Thread Damien Hedde
On 8/7/19 4:41 PM, Peter Maydell wrote: > On Mon, 29 Jul 2019 at 15:58, Damien Hedde wrote: >> >> >> +/** >> + * device_reset: >> + * Resets the device @dev, @cold tell whether to do a cold or warm reset. >> + * Base behavior is to reset the device and its qdev/qbus subtree. > > What do you me

Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus Resettable

2019-08-07 Thread Peter Maydell
On Wed, 7 Aug 2019 at 16:23, Damien Hedde wrote: > On 8/7/19 4:41 PM, Peter Maydell wrote: > > On Mon, 29 Jul 2019 at 15:58, Damien Hedde > > wrote: > >> legacy resets are called in the "post" order (ie: children then parent) > >> in hierarchical reset. That is the same order as legacy qdev_rese

Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus Resettable

2019-08-07 Thread Damien Hedde
On 8/7/19 4:41 PM, Peter Maydell wrote: > On Mon, 29 Jul 2019 at 15:58, Damien Hedde wrote: >> >> This add Resettable interface implementation for both Bus and Device. >> >> *resetting* counter and *reset_is_cold* flag are added in DeviceState >> and BusState. >> >> Compatibility with existing

Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus Resettable

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:58, Damien Hedde wrote: > > This add Resettable interface implementation for both Bus and Device. > > *resetting* counter and *reset_is_cold* flag are added in DeviceState > and BusState. > > Compatibility with existing code base is ensured. > The legacy bus or device res

Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus Resettable

2019-08-07 Thread Damien Hedde
On 8/6/19 2:35 AM, David Gibson wrote: > On Wed, Jul 31, 2019 at 11:09:05AM +0200, Damien Hedde wrote: >> >> >> On 7/31/19 7:56 AM, David Gibson wrote: >>> On Mon, Jul 29, 2019 at 04:56:25PM +0200, Damien Hedde wrote: This add Resettable interface implementation for both Bus and Device. >>>

Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus Resettable

2019-08-06 Thread David Gibson
On Wed, Jul 31, 2019 at 11:09:05AM +0200, Damien Hedde wrote: > > > On 7/31/19 7:56 AM, David Gibson wrote: > > On Mon, Jul 29, 2019 at 04:56:25PM +0200, Damien Hedde wrote: > >> This add Resettable interface implementation for both Bus and Device. > >> > >> *resetting* counter and *reset_is_cold

Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus Resettable

2019-07-31 Thread Damien Hedde
On 7/31/19 7:56 AM, David Gibson wrote: > On Mon, Jul 29, 2019 at 04:56:25PM +0200, Damien Hedde wrote: >> This add Resettable interface implementation for both Bus and Device. >> >> *resetting* counter and *reset_is_cold* flag are added in DeviceState >> and BusState. >> >> Compatibility with e

Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus Resettable

2019-07-30 Thread David Gibson
On Mon, Jul 29, 2019 at 04:56:25PM +0200, Damien Hedde wrote: > This add Resettable interface implementation for both Bus and Device. > > *resetting* counter and *reset_is_cold* flag are added in DeviceState > and BusState. > > Compatibility with existing code base is ensured. > The legacy bus or