Re: [Qemu-devel] [PATCH v3 04/13] sm501: QOMify

2017-03-04 Thread Peter Maydell
On 3 March 2017 at 20:56, BALATON Zoltan wrote: > On Fri, 3 Mar 2017, Peter Maydell wrote: >> Just noticed this. I think reporting the error upwards by >> failing device realize is better than adjusting the value. >> It's what we tend to do for other devices. Management tools >> like libvirt prefe

Re: [Qemu-devel] [PATCH v3 04/13] sm501: QOMify

2017-03-03 Thread BALATON Zoltan
On Fri, 3 Mar 2017, Peter Maydell wrote: On 3 March 2017 at 01:03, BALATON Zoltan wrote: Adding vmstate saving is not in this patch because the state structure will be changed in further patches, then another patch will add vmstate descriptor after those changes. Signed-off-by: BALATON Zoltan

Re: [Qemu-devel] [PATCH v3 04/13] sm501: QOMify

2017-03-03 Thread Peter Maydell
On 3 March 2017 at 01:03, BALATON Zoltan wrote: > Adding vmstate saving is not in this patch because the state structure > will be changed in further patches, then another patch will add > vmstate descriptor after those changes. > > Signed-off-by: BALATON Zoltan > +static void sm501_init(SM501St

Re: [Qemu-devel] [PATCH v3 04/13] sm501: QOMify

2017-03-03 Thread Peter Maydell
On 3 March 2017 at 01:03, BALATON Zoltan wrote: > Adding vmstate saving is not in this patch because the state structure > will be changed in further patches, then another patch will add > vmstate descriptor after those changes. > > Signed-off-by: BALATON Zoltan > --- Reviewed-by: Peter Maydell