Re: [Qemu-devel] [PATCH v3] build-sys: add --disable-vhost-user

2017-08-08 Thread Thomas Huth
On 08.08.2017 14:37, Marc-André Lureau wrote: > Hi > > On Sun, Aug 6, 2017 at 11:19 PM Paolo Bonzini > wrote: > > On 05/08/2017 09:39, Thomas Huth wrote: > >> +CONFIG_VHOST_USER_SCSI=$(and $(CONFIG_VHOST_USER),$(CONFIG_LINUX)) > > I have to say that I don'

Re: [Qemu-devel] [PATCH v3] build-sys: add --disable-vhost-user

2017-08-08 Thread Marc-André Lureau
Hi On Sun, Aug 6, 2017 at 11:19 PM Paolo Bonzini wrote: > On 05/08/2017 09:39, Thomas Huth wrote: > >> +CONFIG_VHOST_USER_SCSI=$(and $(CONFIG_VHOST_USER),$(CONFIG_LINUX)) > > I have to say that I don't really like using $(and ...) in our makefiles > > like this. You rely on the fact that the con

Re: [Qemu-devel] [PATCH v3] build-sys: add --disable-vhost-user

2017-08-06 Thread Paolo Bonzini
On 05/08/2017 09:39, Thomas Huth wrote: >> +CONFIG_VHOST_USER_SCSI=$(and $(CONFIG_VHOST_USER),$(CONFIG_LINUX)) > I have to say that I don't really like using $(and ...) in our makefiles > like this. You rely on the fact that the config variables are either set > to "y" or not set at all ... but if

Re: [Qemu-devel] [PATCH v3] build-sys: add --disable-vhost-user

2017-08-05 Thread Thomas Huth
On 03.08.2017 11:07, Marc-André Lureau wrote: > Learn to compile out vhost-user (net, scsi & upcoming users). Keep it > enabled by default on non-win32, that is assumed to be POSIX. Fail if > trying to enable it on win32. > > When trying to make a vhost-user netdev, it gives the following error: >

Re: [Qemu-devel] [PATCH v3] build-sys: add --disable-vhost-user

2017-08-03 Thread Cornelia Huck
On Thu, 3 Aug 2017 11:07:46 +0200 Marc-André Lureau wrote: > Learn to compile out vhost-user (net, scsi & upcoming users). Keep it > enabled by default on non-win32, that is assumed to be POSIX. Fail if > trying to enable it on win32. > > When trying to make a vhost-user netdev, it gives the fo