Re: [Qemu-devel] [PATCH v3] Add timestamp to error message

2013-06-28 Thread Seiji Aguchi
Thank you for the review. > > +#include "qemu-common.h" > > + > > +/* "1970-01-01T00:00:00.99Z" + '\0' */ > > +#define TIMESTAMP_LEN 28 > > Self-documenting constants are nicer: > > #define TIMESTAMP_LEN (sizeof("1970-01-01T00:00:00.99Z")+1) I will fix it. > > extern void qemu_get_ti

Re: [Qemu-devel] [PATCH v3] Add timestamp to error message

2013-06-27 Thread Eric Blake
On 06/26/2013 04:20 PM, Seiji Aguchi wrote: > [Issue] > When we offer a customer support service and a problem happens > in a customer's system, we try to understand the problem by > comparing what the customer reports with message logs of the > customer's system. > > +#include "qemu-common.h" >

Re: [Qemu-devel] [PATCH v3] Add timestamp to error message

2013-06-26 Thread Seiji Aguchi
> Signed-off-by: Seiji Aguchi I used wrong email address to Signed-off-by. Please ignore this patch. Seiji > -Original Message- > From: qemu-devel-bounces+seiji.aguchi=hds@nongnu.org > [mailto:qemu-devel-bounces+seiji.aguchi=hds@nongnu.org] > On Behalf Of Seiji Aguchi > Sent: