Re: [Qemu-devel] [PATCH v2 5/7] s390x/tcg: implement SET CLOCK

2018-06-21 Thread Cornelia Huck
On Thu, 21 Jun 2018 16:01:22 +0200 David Hildenbrand wrote: > On 21.06.2018 15:14, Thomas Huth wrote: > > On 20.06.2018 12:08, David Hildenbrand wrote: > >> +/* Set Clock */ > >> +uint32_t HELPER(sck)(CPUS390XState *env, uint64_t tod_low) > >> +{ > >> +S390TODState *td = s390_get_tod(); >

Re: [Qemu-devel] [PATCH v2 5/7] s390x/tcg: implement SET CLOCK

2018-06-21 Thread David Hildenbrand
On 21.06.2018 15:14, Thomas Huth wrote: > On 20.06.2018 12:08, David Hildenbrand wrote: >> This allows a guest to change its TOD. We already take care of updating >> all CKC timers from within S390TODClass. >> >> Use MO_ALIGN to load the operand manually - this will properly trigger a >> SPECIFICAT

Re: [Qemu-devel] [PATCH v2 5/7] s390x/tcg: implement SET CLOCK

2018-06-21 Thread Thomas Huth
On 20.06.2018 12:08, David Hildenbrand wrote: > This allows a guest to change its TOD. We already take care of updating > all CKC timers from within S390TODClass. > > Use MO_ALIGN to load the operand manually - this will properly trigger a > SPECIFICATION exception. > > Signed-off-by: David Hilde