Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone disassembler library

2017-09-26 Thread Richard Henderson
On 09/19/2017 08:03 AM, Richard Henderson wrote: > +while (1) { > +/* We want to read memory for one insn, but generically we do not > + know how much memory that is. We have a small buffer which is > + known to be sufficient for all supported targets. Try to not >

Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone disassembler library

2017-09-20 Thread Richard Henderson
On 09/20/2017 06:17 AM, Alex Bennée wrote: > Hmm I get a link failure: > > LINKtilegx-linux-user/qemu-tilegx > disas.o: In function `cap_disas_start': > /home/alex/lsrc/qemu/qemu.git/disas.c:196: undefined reference to `cs_open' As discussed on IRC, this turned out to be wrong link ordering

Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone disassembler library

2017-09-20 Thread Alex Bennée
Richard Henderson writes: > If configured, prefer this over our rather dated copy of the > GPLv2-only binutils. This will be especially apparent with > the proposed vector extensions to TCG, as disas/i386.c does > not handle AVX. > > Signed-off-by: Richard Henderson Hmm I get a link failure:

Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone disassembler library

2017-09-20 Thread Richard Henderson
On 09/20/2017 06:17 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> If configured, prefer this over our rather dated copy of the >> GPLv2-only binutils. This will be especially apparent with >> the proposed vector extensions to TCG, as disas/i386.c does >> not handle AVX. >> >> Signed