Re: [Qemu-devel] [PATCH v2 33/37] tests: add qtest_add_data_func_full

2016-08-01 Thread Eric Blake
On 07/29/2016 02:48 AM, Marc-André Lureau wrote: >>> +#if GLIB_CHECK_VERSION(2, 34, 0) >>> +gchar *path = g_strdup_printf("/%s/%s", qtest_get_arch(), str); >>> +g_test_add_data_func_full(path, data, fn, data_free_func); >>> +g_free(path); >>> +#else >>> +qtest_add_data_func(str, da

Re: [Qemu-devel] [PATCH v2 33/37] tests: add qtest_add_data_func_full

2016-07-29 Thread Marc-André Lureau
Hi On Fri, Jul 29, 2016 at 2:16 AM, Eric Blake wrote: > On 07/28/2016 08:38 AM, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Allows to specify a destroy function for the test data. > > "Allows to" is not idiomatic English. Alternatives that sound better are > "Allows $who

Re: [Qemu-devel] [PATCH v2 33/37] tests: add qtest_add_data_func_full

2016-07-28 Thread Eric Blake
On 07/28/2016 08:38 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Allows to specify a destroy function for the test data. "Allows to" is not idiomatic English. Alternatives that sound better are "Allows $who to specify" (most simply, "Allows one to"), or "Allows specifying