Re: [Qemu-devel] [PATCH v2 3/6] x86: fill high bits of mtrr mask

2016-07-05 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Mon, Jul 04, 2016 at 08:16:06PM +0100, Dr. David Alan Gilbert (git) wrote: > [...] > > @@ -2084,6 +2085,27 @@ static int kvm_get_msrs(X86CPU *cpu) > > } > > > > assert(ret == cpu->kvm_msr_buf->nmsrs); > > +/* > > + * MTRR masks

Re: [Qemu-devel] [PATCH v2 3/6] x86: fill high bits of mtrr mask

2016-07-04 Thread Eduardo Habkost
On Mon, Jul 04, 2016 at 08:16:06PM +0100, Dr. David Alan Gilbert (git) wrote: [...] > @@ -2084,6 +2085,27 @@ static int kvm_get_msrs(X86CPU *cpu) > } > > assert(ret == cpu->kvm_msr_buf->nmsrs); > +/* > + * MTRR masks: Each mask consists of 5 parts > + * a 10..0: must be zer

Re: [Qemu-devel] [PATCH v2 3/6] x86: fill high bits of mtrr mask

2016-07-04 Thread Eduardo Habkost
On Mon, Jul 04, 2016 at 11:03:59PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 04, 2016 at 08:16:06PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Fill the bits between 51..number-of-physical-address-bits in the > > MTRR_PHYSMASKn variable range mtrr ma

Re: [Qemu-devel] [PATCH v2 3/6] x86: fill high bits of mtrr mask

2016-07-04 Thread Michael S. Tsirkin
On Mon, Jul 04, 2016 at 08:16:06PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Fill the bits between 51..number-of-physical-address-bits in the > MTRR_PHYSMASKn variable range mtrr masks so that they're consistent > in the migration stream irrespective of the p