Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-17 Thread Halil Pasic
On 10/12/2017 01:44 PM, Halil Pasic wrote: > > > On 10/12/2017 08:58 AM, Thomas Huth wrote: >> On 10.10.2017 13:41, Halil Pasic wrote: [..] >> So yes, please don't do a "typedef unsigned int IOInstEnding" either. I >> think the best match for QEMU would be a >> >> typedef enum IOInstEnding { >>

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-12 Thread Halil Pasic
On 10/12/2017 08:58 AM, Thomas Huth wrote: > On 10.10.2017 13:41, Halil Pasic wrote: >> [..] Yeah, the ABI is smart enough (where it matters) and this one is obviously less that 8 bytes. I read this as you assumed that the return won't be passed via register (general purpose

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-11 Thread Thomas Huth
On 10.10.2017 13:41, Halil Pasic wrote: > [..] >>> >>> Yeah, the ABI is smart enough (where it matters) and this one is obviously >>> less that 8 bytes. I read this as you assumed that the return won't be >>> passed via register (general purpose register 2 for a z host + ELF assumed), >>> and that

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-10 Thread Halil Pasic
On 10/10/2017 01:39 PM, Cornelia Huck wrote: > On Tue, 10 Oct 2017 12:28:35 +0200 > Thomas Huth wrote: > >> On 09.10.2017 17:00, Halil Pasic wrote: >>> >>> >>> On 10/09/2017 01:07 PM, Thomas Huth wrote: > Then, in the follow up patches, you do something like this: return (I

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-10 Thread Halil Pasic
[..] >> >> Yeah, the ABI is smart enough (where it matters) and this one is obviously >> less that 8 bytes. I read this as you assumed that the return won't be >> passed via register (general purpose register 2 for a z host + ELF assumed), >> and that would have been ugly indeed. >> >> Btw I have

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-10 Thread Cornelia Huck
On Tue, 10 Oct 2017 12:28:35 +0200 Thomas Huth wrote: > On 09.10.2017 17:00, Halil Pasic wrote: > > > > > > On 10/09/2017 01:07 PM, Thomas Huth wrote: > >> Then, in the follow up patches, you do something like this: > >> > >>return (IOInstEnding){.cc = 0}; > >> > >> ... and that just loo

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-10 Thread Thomas Huth
On 09.10.2017 17:00, Halil Pasic wrote: > > > On 10/09/2017 01:07 PM, Thomas Huth wrote: >> On 09.10.2017 12:54, Halil Pasic wrote: >>> >>> >>> On 10/09/2017 10:20 AM, Thomas Huth wrote: On 04.10.2017 17:41, Halil Pasic wrote: > CSS code needs to tell the IO instruction handlers located

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-09 Thread Halil Pasic
On 10/09/2017 01:09 PM, Cornelia Huck wrote: > On Mon, 9 Oct 2017 12:54:03 +0200 > Halil Pasic wrote: > >> On 10/09/2017 10:20 AM, Thomas Huth wrote: >>> On 04.10.2017 17:41, Halil Pasic wrote: > +/* IO instructions conclude according this */ +typedef struct IOInstEnding { +

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-09 Thread Halil Pasic
On 10/09/2017 01:07 PM, Thomas Huth wrote: > On 09.10.2017 12:54, Halil Pasic wrote: >> >> >> On 10/09/2017 10:20 AM, Thomas Huth wrote: >>> On 04.10.2017 17:41, Halil Pasic wrote: CSS code needs to tell the IO instruction handlers located in how should >>> >>> located in how? >>> >> >> Firs

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-09 Thread Cornelia Huck
On Mon, 9 Oct 2017 12:54:03 +0200 Halil Pasic wrote: > On 10/09/2017 10:20 AM, Thomas Huth wrote: > > On 04.10.2017 17:41, Halil Pasic wrote: > >> +/* IO instructions conclude according this */ > >> +typedef struct IOInstEnding { > >> +/* > >> + * General semantic of cc codes o

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-09 Thread Thomas Huth
On 09.10.2017 12:54, Halil Pasic wrote: > > > On 10/09/2017 10:20 AM, Thomas Huth wrote: >> On 04.10.2017 17:41, Halil Pasic wrote: >>> CSS code needs to tell the IO instruction handlers located in how should >> >> located in how? >> > > First, thanks for your review! > > Wanted to say: in targ

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-09 Thread Halil Pasic
On 10/09/2017 10:20 AM, Thomas Huth wrote: > On 04.10.2017 17:41, Halil Pasic wrote: >> CSS code needs to tell the IO instruction handlers located in how should > > located in how? > First, thanks for your review! Wanted to say: in target/s390x/ioinst.c just forgot to copy paste. >> the emul

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-09 Thread Thomas Huth
On 04.10.2017 17:41, Halil Pasic wrote: > CSS code needs to tell the IO instruction handlers located in how should located in how? > the emulated instruction be ended. Currently this is done by returning > generic (POSIX) error codes, and mapping them to outcomes like condition > codes. This make