Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-11 Thread Eduardo Habkost
On Wed, Jul 11, 2018 at 07:00:54PM +0200, Sebastian Bauer wrote: > Am 2018-07-11 17:48, schrieb Eduardo Habkost: > > "none" looked like a false positive when I first looked, but now > > I think it's not. Shouldn't it set default_display="none"? > > I think that there is some other logic burried t

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-11 Thread Sebastian Bauer
Am 2018-07-11 17:48, schrieb Eduardo Habkost: "none" looked like a false positive when I first looked, but now I think it's not. Shouldn't it set default_display="none"? I think that there is some other logic burried that these machine doesn't get a graphics display. But overall it is indeed

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-11 Thread Eduardo Habkost
On Tue, Jul 10, 2018 at 12:26:52AM +0200, Sebastian Bauer wrote: > Hi, > > Am 2018-07-09 23:23, schrieb Eduardo Habkost: > > List of machines with default_display==NULL on those > > architectures: > > > > alpha: > > none empty machine > > > > mips: > > mipssim MIPS M

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-09 Thread Sebastian Bauer
Hi, Am 2018-07-09 23:23, schrieb Eduardo Habkost: List of machines with default_display==NULL on those architectures: alpha: none empty machine mips: mipssim MIPS MIPSsim platform none empty machine ppc*: bamboo bamboo mpc8544ds

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-09 Thread Eduardo Habkost
On Fri, Jul 06, 2018 at 08:53:42AM +0200, Gerd Hoffmann wrote: > On Thu, Jul 05, 2018 at 01:35:01PM -0300, Eduardo Habkost wrote: > > Do we have a list of all machine-types with default_display==NULL > > that would be affected by this? > > There are not many which use the default vga thing in the

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-09 Thread Eduardo Habkost
On Mon, Jul 09, 2018 at 06:08:33PM -0300, Eduardo Habkost wrote: > On Fri, Jul 06, 2018 at 08:53:42AM +0200, Gerd Hoffmann wrote: > > On Thu, Jul 05, 2018 at 01:35:01PM -0300, Eduardo Habkost wrote: > > > Do we have a list of all machine-types with default_display==NULL > > > that would be affected

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-05 Thread Gerd Hoffmann
On Thu, Jul 05, 2018 at 01:35:01PM -0300, Eduardo Habkost wrote: > Do we have a list of all machine-types with default_display==NULL > that would be affected by this? There are not many which use the default vga thing in the first place. Workflow is this: (1) vl.c calls select_vgahw(vga_model) a

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-05 Thread Eduardo Habkost
On Thu, Jul 05, 2018 at 08:43:48AM +0200, Gerd Hoffmann wrote: > Now that all machines which need cirrus explicitly select it qemu > doesn't need to consider it as default display any more. Drop it. > > With this patch applied all ppc machine types will use "std" as default > display, no matter w