Re: [Qemu-devel] [PATCH v2 12/29] Include hw/irq.h a lot less

2019-08-08 Thread Eric Blake
On 8/7/19 11:27 PM, Markus Armbruster wrote: /* * Function types */ typedef void SaveStateHandler(QEMUFile *f, void *opaque); typedef int LoadStateHandler(QEMUFile *f, void *opaque, int version_id); +typedef void (*qemu_irq_handler)(void *opaque, int n, int lev

Re: [Qemu-devel] [PATCH v2 12/29] Include hw/irq.h a lot less

2019-08-07 Thread Richard Henderson
On 8/7/19 9:27 PM, Markus Armbruster wrote: typedef void SaveStateHandler(QEMUFile *f, void *opaque); typedef int LoadStateHandler(QEMUFile *f, void *opaque, int version_id); +typedef void (*qemu_irq_handler)(void *opaque, int n, int level); >> >> Should we prefer a consistent form

Re: [Qemu-devel] [PATCH v2 12/29] Include hw/irq.h a lot less

2019-08-07 Thread Markus Armbruster
Eric Blake writes: > On 8/7/19 8:04 AM, Philippe Mathieu-Daudé wrote: >> On 8/6/19 5:14 PM, Markus Armbruster wrote: >>> In my "build everything" tree, changing hw/irq.h triggers a recompile >>> of some 5400 out of 6600 objects (not counting tests and objects that >>> don't depend on qemu/osdep.h

Re: [Qemu-devel] [PATCH v2 12/29] Include hw/irq.h a lot less

2019-08-07 Thread Eric Blake
On 8/7/19 8:04 AM, Philippe Mathieu-Daudé wrote: > On 8/6/19 5:14 PM, Markus Armbruster wrote: >> In my "build everything" tree, changing hw/irq.h triggers a recompile >> of some 5400 out of 6600 objects (not counting tests and objects that >> don't depend on qemu/osdep.h). >> >> hw/hw.h supposedly

Re: [Qemu-devel] [PATCH v2 12/29] Include hw/irq.h a lot less

2019-08-07 Thread Philippe Mathieu-Daudé
On 8/6/19 5:14 PM, Markus Armbruster wrote: > In my "build everything" tree, changing hw/irq.h triggers a recompile > of some 5400 out of 6600 objects (not counting tests and objects that > don't depend on qemu/osdep.h). > > hw/hw.h supposedly includes it for convenience. Several other headers >