Re: [Qemu-devel] [PATCH v2 11/15] bitmap: add a generic bitmap and bitops library

2010-11-11 Thread Corentin Chary
On Thu, Nov 11, 2010 at 8:07 PM, Blue Swirl wrote: > Please don't use identifiers starting with underscore. Ok, I think __bitmap_* could become slow__bitmap_* (because they are the slow path) > We already have ffs() in qemu-common.h and oslib-win32.c. Please use > the same method. > This is no

Re: [Qemu-devel] [PATCH v2 11/15] bitmap: add a generic bitmap and bitops library

2010-11-11 Thread Blue Swirl
On Thu, Nov 11, 2010 at 4:57 PM, Corentin Chary wrote: > Add most used bitmap and bitops functions into bitmap.c and bitops.c. > Theses functions are mostly copied from Linux kernel source. > > Some of these functions are already redefined in the VNC server. Some > of them could be used for some b