Re: [Qemu-devel] [PATCH v2 06/13] tcg: add goto_ptr opcode

2017-04-25 Thread Richard Henderson
On 04/25/2017 09:53 AM, Emilio G. Cota wrote: +void tcg_gen_goto_ptr(TCGv_ptr ptr) +{ +if (TCG_TARGET_HAS_goto_ptr) { +tcg_gen_op1i(INDEX_op_goto_ptr, GET_TCGV_PTR(ptr)); +} else { +tcg_gen_exit_tb(0); +} +} + I think this function should look more like void tcg_gen

Re: [Qemu-devel] [PATCH v2 06/13] tcg: add goto_ptr opcode

2017-04-25 Thread Richard Henderson
On 04/25/2017 09:53 AM, Emilio G. Cota wrote: @@ -1138,6 +1138,7 @@ void tcg_dump_ops(TCGContext *s) } switch (c) { case INDEX_op_set_label: +case INDEX_op_goto_tb: case INDEX_op_br: case INDEX_op_brcond_i32: