Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

2019-01-29 Thread Wei Yang
On Tue, Jan 29, 2019 at 10:58:50AM -0500, Michael S. Tsirkin wrote: >On Tue, Jan 29, 2019 at 03:32:54PM +, Wei Yang wrote: >> On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote: >> >On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote: >> >> On 1/29/19 9:04 AM, Wei Yang wrote: >> >>> O

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

2019-01-29 Thread Wei Yang
On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote: >On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote: >> On 1/29/19 9:04 AM, Wei Yang wrote: >>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: Hi Wei, On 1/29/19 1:08 AM, Wei Yang wrote: > The

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

2019-01-29 Thread Michael S. Tsirkin
On Tue, Jan 29, 2019 at 03:32:54PM +, Wei Yang wrote: > On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote: > >On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote: > >> On 1/29/19 9:04 AM, Wei Yang wrote: > >>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: >

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

2019-01-29 Thread Laurent Vivier
On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote: > On 1/29/19 9:04 AM, Wei Yang wrote: >> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: >>> Hi Wei, >>> >>> On 1/29/19 1:08 AM, Wei Yang wrote: There are several functions/variable which are not used anymore.

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

2019-01-29 Thread Philippe Mathieu-Daudé
On 1/29/19 9:04 AM, Wei Yang wrote: > On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: >> Hi Wei, >> >> On 1/29/19 1:08 AM, Wei Yang wrote: >>> There are several functions/variable which are not used anymore. >>> >>> This serials just remove those without functional change. >

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

2019-01-29 Thread Wei Yang
On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: >Hi Wei, > >On 1/29/19 1:08 AM, Wei Yang wrote: >> There are several functions/variable which are not used anymore. >> >> This serials just remove those without functional change. >> >> Wei Yang (3): >> hw/i386/pc.c: remove

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

2019-01-28 Thread Philippe Mathieu-Daudé
Hi Wei, On 1/29/19 1:08 AM, Wei Yang wrote: > There are several functions/variable which are not used anymore. > > This serials just remove those without functional change. > > Wei Yang (3): > hw/i386/pc.c: remove unused function pc_acpi_init() > hw/acpi: remove unused function acpi_table_ad