Re: [Qemu-devel] [PATCH v2] win32: Fix CRLF problem in make_device_config.sh

2010-12-30 Thread Andreas Färber
Am 19.12.2010 um 17:06 schrieb Andreas Färber: Am 19.12.2010 um 16:42 schrieb Stefan Weil: Am 18.12.2010 19:59, schrieb Blue Swirl: Thanks, applied. On Sat, Dec 18, 2010 at 5:09 PM, Andreas Färber > wrote: Am 18.12.2010 um 17:34 schrieb Stefan Weil: QEMU source code with CRLF line endings

Re: [Qemu-devel] [PATCH v2] win32: Fix CRLF problem in make_device_config.sh

2010-12-20 Thread Paolo Bonzini
On 12/19/2010 05:06 PM, Andreas Färber wrote: Andreas, may I ask you for one more test? $ echo -e 'include xy\r' | tr -d '\r' | awk '/^include / {ORS=""; print $2}' | od -c I'd not bother with ORS and use '$1 == "include" { printf "%s", $2 }' instead. Paolo

Re: [Qemu-devel] [PATCH v2] win32: Fix CRLF problem in make_device_config.sh

2010-12-19 Thread Andreas Färber
Am 19.12.2010 um 17:21 schrieb Blue Swirl: On Sun, Dec 19, 2010 at 3:42 PM, Stefan Weil wrote: Am 18.12.2010 19:59, schrieb Blue Swirl: Thanks, applied. On Sat, Dec 18, 2010 at 5:09 PM, Andreas Färber > wrote: Am 18.12.2010 um 17:34 schrieb Stefan Weil: QEMU source code with CRLF line

Re: [Qemu-devel] [PATCH v2] win32: Fix CRLF problem in make_device_config.sh

2010-12-19 Thread Blue Swirl
On Sun, Dec 19, 2010 at 3:42 PM, Stefan Weil wrote: > Am 18.12.2010 19:59, schrieb Blue Swirl: >> >> Thanks, applied. >> >> On Sat, Dec 18, 2010 at 5:09 PM, Andreas Färber >> wrote: >>> >>> Am 18.12.2010 um 17:34 schrieb Stefan Weil: >>> QEMU source code with CRLF line endings which is

Re: [Qemu-devel] [PATCH v2] win32: Fix CRLF problem in make_device_config.sh

2010-12-19 Thread Andreas Färber
Am 19.12.2010 um 16:42 schrieb Stefan Weil: Am 18.12.2010 19:59, schrieb Blue Swirl: Thanks, applied. On Sat, Dec 18, 2010 at 5:09 PM, Andreas Färber > wrote: Am 18.12.2010 um 17:34 schrieb Stefan Weil: QEMU source code with CRLF line endings which is quite common on windows hosts fails wit

Re: [Qemu-devel] [PATCH v2] win32: Fix CRLF problem in make_device_config.sh

2010-12-19 Thread Stefan Weil
Am 18.12.2010 19:59, schrieb Blue Swirl: Thanks, applied. On Sat, Dec 18, 2010 at 5:09 PM, Andreas Färber wrote: Am 18.12.2010 um 17:34 schrieb Stefan Weil: QEMU source code with CRLF line endings which is quite common on windows hosts fails with current make_device_config.sh. The awk scri

Re: [Qemu-devel] [PATCH v2] win32: Fix CRLF problem in make_device_config.sh

2010-12-18 Thread Blue Swirl
Thanks, applied. On Sat, Dec 18, 2010 at 5:09 PM, Andreas Färber wrote: > Am 18.12.2010 um 17:34 schrieb Stefan Weil: > >> QEMU source code with CRLF line endings >> which is quite common on windows hosts >> fails with current make_device_config.sh. >> >> The awk script gets the name of the inclu

Re: [Qemu-devel] [PATCH v2] win32: Fix CRLF problem in make_device_config.sh

2010-12-18 Thread Andreas Färber
Am 18.12.2010 um 17:34 schrieb Stefan Weil: QEMU source code with CRLF line endings which is quite common on windows hosts fails with current make_device_config.sh. The awk script gets the name of the included file with \r, so instead of pci.mak it will search for pci.mak\r which of course does