Re: [Qemu-devel] [PATCH v2] vmdk: fix cluster size check for flat extents

2013-09-25 Thread Fam Zheng
On Mon, 09/23 17:18, Fam Zheng wrote: > We use the extent size as cluster size for flat extents (where no L1/L2 > table is allocated so it's safe) reuse sector calculating code with > sparse extents. > > Don't pass in the cluster size for adding flat extent, just set it to > sectors later, then th

Re: [Qemu-devel] [PATCH v2] vmdk: fix cluster size check for flat extents

2013-09-24 Thread Stefan Hajnoczi
On Mon, Sep 23, 2013 at 05:18:29PM +0800, Fam Zheng wrote: > We use the extent size as cluster size for flat extents (where no L1/L2 > table is allocated so it's safe) reuse sector calculating code with > sparse extents. > > Don't pass in the cluster size for adding flat extent, just set it to > s

Re: [Qemu-devel] [PATCH v2] vmdk: fix cluster size check for flat extents

2013-09-23 Thread Fam Zheng
On Mon, 09/23 17:18, Fam Zheng wrote: > We use the extent size as cluster size for flat extents (where no L1/L2 > table is allocated so it's safe) reuse sector calculating code with > sparse extents. > > Don't pass in the cluster size for adding flat extent, just set it to > sectors later, then th