Re: [Qemu-devel] [PATCH v2] usb: assign unique serial numbers to hid devices

2018-09-19 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> OK, so now I've found the bit about the magic 42; commit 7b074a22 of >> yours; recommended checking for 42 for knowing we had autosuspend; >> what's actually in the current fedora hid rules is serial!=1 - I wonder >> what others have. > > Whatever upstream syste

Re: [Qemu-devel] [PATCH v2] usb: assign unique serial numbers to hid devices

2018-09-17 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > > > And even if it turns out autosuspend is still an issue: I think > > > meanwhile we can really stop worrying about guests running in old qemu > > > versions with broken usb suspend (fixed in 0.13 !). If needed we can > > > enable autosuspend uncondi

Re: [Qemu-devel] [PATCH v2] usb: assign unique serial numbers to hid devices

2018-09-16 Thread Gerd Hoffmann
> > And even if it turns out autosuspend is still an issue: I think > > meanwhile we can really stop worrying about guests running in old qemu > > versions with broken usb suspend (fixed in 0.13 !). If needed we can > > enable autosuspend unconditionally in guests. > > OK, so what about the othe

Re: [Qemu-devel] [PATCH v2] usb: assign unique serial numbers to hid devices

2018-09-14 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > > OK, so now I've found the bit about the magic 42; commit 7b074a22 of > > yours; recommended checking for 42 for knowing we had autosuspend; > > what's actually in the current fedora hid rules is serial!=1 - I wonder > > what others have. >

Re: [Qemu-devel] [PATCH v2] usb: assign unique serial numbers to hid devices

2018-09-14 Thread Gerd Hoffmann
Hi, > OK, so now I've found the bit about the magic 42; commit 7b074a22 of > yours; recommended checking for 42 for knowing we had autosuspend; > what's actually in the current fedora hid rules is serial!=1 - I wonder > what others have. Whatever upstream systemd/udev has I guess ... A bit of

Re: [Qemu-devel] [PATCH v2] usb: assign unique serial numbers to hid devices

2018-09-14 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Windows guests have trouble dealing with usb devices having identical > serial numbers. So, assign unique serial numbers to usb hid devices. > All other usb devices have this already. > > Signed-off-by: Gerd Hoffmann > --- > include/hw/compat.h | 14