Re: [Qemu-devel] [PATCH v2] socket: allow wait=false for client socket

2019-04-15 Thread Daniel P . Berrangé
On Mon, Apr 15, 2019 at 06:16:33PM +0200, Marc-André Lureau wrote: > On Mon, Apr 15, 2019 at 6:08 PM Daniel P. Berrangé > wrote: > > > > On Mon, Apr 15, 2019 at 06:06:09PM +0200, Marc-André Lureau wrote: > > > Commit 767abe7 ("chardev: forbid 'wait' option with client sockets") > > > is a bit too

Re: [Qemu-devel] [PATCH v2] socket: allow wait=false for client socket

2019-04-15 Thread Marc-André Lureau
On Mon, Apr 15, 2019 at 6:08 PM Daniel P. Berrangé wrote: > > On Mon, Apr 15, 2019 at 06:06:09PM +0200, Marc-André Lureau wrote: > > Commit 767abe7 ("chardev: forbid 'wait' option with client sockets") > > is a bit too strict. Current libvirt always set wait=false, and will > > thus fail to add cl

Re: [Qemu-devel] [PATCH v2] socket: allow wait=false for client socket

2019-04-15 Thread Daniel P . Berrangé
On Mon, Apr 15, 2019 at 06:06:09PM +0200, Marc-André Lureau wrote: > Commit 767abe7 ("chardev: forbid 'wait' option with client sockets") > is a bit too strict. Current libvirt always set wait=false, and will > thus fail to add client chardev. > > Make the code more permissive, allowing wait=false