Re: [Qemu-devel] [PATCH v2] qemu-nbd: Implement socket activation.

2017-02-04 Thread Markus Armbruster
"Richard W.M. Jones" writes: > On Fri, Feb 03, 2017 at 03:16:43PM +, Stefan Hajnoczi wrote: >> On Thu, Feb 02, 2017 at 05:16:25PM +, Richard W.M. Jones wrote: >> > +if (*port == NULL) { >> > +*port = g_strdup_printf("%d", NBD_DEFAULT_PORT);; >> >> Please stringify NBD_DEFAULT

Re: [Qemu-devel] [PATCH v2] qemu-nbd: Implement socket activation.

2017-02-03 Thread Richard W.M. Jones
On Fri, Feb 03, 2017 at 03:16:43PM +, Stefan Hajnoczi wrote: > On Thu, Feb 02, 2017 at 05:16:25PM +, Richard W.M. Jones wrote: > > +if (*port == NULL) { > > +*port = g_strdup_printf("%d", NBD_DEFAULT_PORT);; > > Please stringify NBD_DEFAULT_PORT instead of using g_strdup_printf

Re: [Qemu-devel] [PATCH v2] qemu-nbd: Implement socket activation.

2017-02-03 Thread Stefan Hajnoczi
On Thu, Feb 02, 2017 at 05:16:25PM +, Richard W.M. Jones wrote: > Socket activation (sometimes known as systemd socket activation) > allows an Internet superserver to pass a pre-opened listening socket > to the process, instead of having qemu-nbd open a socket itself. This > is done via the LI

Re: [Qemu-devel] [PATCH v2] qemu-nbd: Implement socket activation.

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 05:16:25PM +, Richard W.M. Jones wrote: > Socket activation (sometimes known as systemd socket activation) > allows an Internet superserver to pass a pre-opened listening socket > to the process, instead of having qemu-nbd open a socket itself. This > is done via the LI