Re: [Qemu-devel] [PATCH v2] qcow2: Rewrite qcow2_alloc_bytes()

2015-02-06 Thread Max Reitz
On 2015-02-06 at 09:08, Kevin Wolf wrote: Am 05.02.2015 um 16:58 hat Max Reitz geschrieben: qcow2_alloc_bytes() is a function with insufficient error handling and an unnecessary goto. This patch rewrites it. Signed-off-by: Max Reitz --- v2: - s/free_cluster_index/free_byte_index/ [Eric] - adde

Re: [Qemu-devel] [PATCH v2] qcow2: Rewrite qcow2_alloc_bytes()

2015-02-06 Thread Kevin Wolf
Am 05.02.2015 um 16:58 hat Max Reitz geschrieben: > qcow2_alloc_bytes() is a function with insufficient error handling and > an unnecessary goto. This patch rewrites it. > > Signed-off-by: Max Reitz > --- > v2: > - s/free_cluster_index/free_byte_index/ [Eric] > - added an assertion at the start o

Re: [Qemu-devel] [PATCH v2] qcow2: Rewrite qcow2_alloc_bytes()

2015-02-05 Thread Eric Blake
On 02/05/2015 08:58 AM, Max Reitz wrote: > qcow2_alloc_bytes() is a function with insufficient error handling and > an unnecessary goto. This patch rewrites it. > > Signed-off-by: Max Reitz > --- > v2: > - s/free_cluster_index/free_byte_index/ [Eric] > - added an assertion at the start of the fun