Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes

2015-06-24 Thread Paolo Bonzini
On 07/06/2015 23:59, Peter Crosthwaite wrote: > This makes it more consistent with all other core code files, which > either just rely on qemu-common.h inclusion or precede cpu.h with > qemu-common.h. > > cpu-all.h should not be included in addition to cpu.h. Remove it. > > Signed-off-by: Peter

Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes

2015-06-23 Thread Peter Crosthwaite
Ping! On Sun, Jun 7, 2015 at 2:59 PM, Peter Crosthwaite wrote: > This makes it more consistent with all other core code files, which > either just rely on qemu-common.h inclusion or precede cpu.h with > qemu-common.h. > > cpu-all.h should not be included in addition to cpu.h. Remove it. > > Signe

Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes

2015-06-17 Thread Paolo Bonzini
On 09/06/2015 09:42, Peter Crosthwaite wrote: > > Acked-by: Paolo Bonzini > > > > About to leave on vacation, so someone else will have to pick it up. > > Enjoy. If you are not back before soft freeze would you object to me > sending a [PULL] for some of the multi-arch related mainloop header >

Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes

2015-06-09 Thread Peter Crosthwaite
On Mon, Jun 8, 2015 at 3:47 AM, Paolo Bonzini wrote: > > > On 07/06/2015 23:59, Peter Crosthwaite wrote: >> This makes it more consistent with all other core code files, which >> either just rely on qemu-common.h inclusion or precede cpu.h with >> qemu-common.h. >> >> cpu-all.h should not be inclu

Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes

2015-06-08 Thread Paolo Bonzini
On 07/06/2015 23:59, Peter Crosthwaite wrote: > This makes it more consistent with all other core code files, which > either just rely on qemu-common.h inclusion or precede cpu.h with > qemu-common.h. > > cpu-all.h should not be included in addition to cpu.h. Remove it. > > Signed-off-by: Peter