Re: [Qemu-devel] [PATCH v2] iscsi: add error handling for qmp_query_uuid

2013-11-05 Thread Paolo Bonzini
Il 05/11/2013 14:17, Stefan Hajnoczi ha scritto: > On Tue, Nov 05, 2013 at 08:33:14AM +0800, Amos Kong wrote: >> We can't assume that qmp_query_uuid() always returns available value. >> >> Signed-off-by: Amos Kong >> --- >> v2: free errp if it's set >> --- >> block/iscsi.c | 8 ++-- >> 1 file

Re: [Qemu-devel] [PATCH v2] iscsi: add error handling for qmp_query_uuid

2013-11-05 Thread Stefan Hajnoczi
On Tue, Nov 05, 2013 at 08:33:14AM +0800, Amos Kong wrote: > We can't assume that qmp_query_uuid() always returns available value. > > Signed-off-by: Amos Kong > --- > v2: free errp if it's set > --- > block/iscsi.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Reviewed-by: St

Re: [Qemu-devel] [PATCH v2] iscsi: add error handling for qmp_query_uuid

2013-11-04 Thread Laszlo Ersek
On 11/05/13 01:33, Amos Kong wrote: > We can't assume that qmp_query_uuid() always returns available value. > > Signed-off-by: Amos Kong > --- > v2: free errp if it's set > --- > block/iscsi.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/block/iscsi.c b/block