Re: [Qemu-devel] [PATCH v2] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-29 Thread Stefan Hajnoczi
On Thu, Aug 28, 2014 at 09:04:20AM +0100, Richard W.M. Jones wrote: > No change in the patch itself since v1. However I have added a longer > explanation to the commit message. > > Rich. > Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan pgpFPlm857uPX.p

Re: [Qemu-devel] [PATCH v2] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-29 Thread Stefan Hajnoczi
On Fri, Aug 29, 2014 at 10:19:04AM +0100, Richard W.M. Jones wrote: > On Fri, Aug 29, 2014 at 10:03:59AM +0100, Stefan Hajnoczi wrote: > > On Thu, Aug 28, 2014 at 09:04:21AM +0100, Richard W.M. Jones wrote: > > > diff --git a/block/curl.c b/block/curl.c > > > index d4b85d2..f59615d 100644 > > > ---

Re: [Qemu-devel] [PATCH v2] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-29 Thread Richard W.M. Jones
On Fri, Aug 29, 2014 at 10:03:59AM +0100, Stefan Hajnoczi wrote: > On Thu, Aug 28, 2014 at 09:04:21AM +0100, Richard W.M. Jones wrote: > > diff --git a/block/curl.c b/block/curl.c > > index d4b85d2..f59615d 100644 > > --- a/block/curl.c > > +++ b/block/curl.c > > @@ -352,7 +352,7 @@ static void cur

Re: [Qemu-devel] [PATCH v2] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-29 Thread Stefan Hajnoczi
On Thu, Aug 28, 2014 at 09:04:21AM +0100, Richard W.M. Jones wrote: > diff --git a/block/curl.c b/block/curl.c > index d4b85d2..f59615d 100644 > --- a/block/curl.c > +++ b/block/curl.c > @@ -352,7 +352,7 @@ static void curl_multi_timeout_do(void *arg) > #endif > } > > -static CURLState *curl_in

Re: [Qemu-devel] [PATCH v2] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-28 Thread Benoît Canet
The Thursday 28 Aug 2014 à 09:04:21 (+0100), Richard W.M. Jones wrote : > In commit 63f0f45f2e89b60ff8245fec81328ddfde42a303 the following > mechanical change was made: > > if (!state) { > -qemu_aio_wait(); > +aio_poll(state->s->aio_context, true); > } >