Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 14:08, Kevin Wolf wrote: > Am 29.03.2019 um 11:55 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 29.03.2019 13:12, Kevin Wolf wrote: >>> Am 29.03.2019 um 10:53 hat Vladimir Sementsov-Ogievskiy geschrieben: 28.03.2019 21:40, Kevin Wolf wrote: > Am 28.03.2019 um 08:21 hat Vladim

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 14:08, Kevin Wolf wrote: > Am 29.03.2019 um 11:55 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 29.03.2019 13:12, Kevin Wolf wrote: >>> Am 29.03.2019 um 10:53 hat Vladimir Sementsov-Ogievskiy geschrieben: 28.03.2019 21:40, Kevin Wolf wrote: > Am 28.03.2019 um 08:21 hat Vladim

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Kevin Wolf
Am 29.03.2019 um 11:55 hat Vladimir Sementsov-Ogievskiy geschrieben: > 29.03.2019 13:12, Kevin Wolf wrote: > > Am 29.03.2019 um 10:53 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 28.03.2019 21:40, Kevin Wolf wrote: > >>> Am 28.03.2019 um 08:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > >

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 13:55, Vladimir Sementsov-Ogievskiy wrote: > 29.03.2019 13:12, Kevin Wolf wrote: >> Am 29.03.2019 um 10:53 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> 28.03.2019 21:40, Kevin Wolf wrote: Am 28.03.2019 um 08:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > bdrv_replace_ch

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 13:12, Kevin Wolf wrote: > Am 29.03.2019 um 10:53 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 28.03.2019 21:40, Kevin Wolf wrote: >>> Am 28.03.2019 um 08:21 hat Vladimir Sementsov-Ogievskiy geschrieben: bdrv_replace_child() calls bdrv_check_perm() with error_abort on loose

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Kevin Wolf
Am 29.03.2019 um 10:53 hat Vladimir Sementsov-Ogievskiy geschrieben: > 28.03.2019 21:40, Kevin Wolf wrote: > > Am 28.03.2019 um 08:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> bdrv_replace_child() calls bdrv_check_perm() with error_abort on > >> loosening permissions. However file-locking

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
28.03.2019 21:40, Kevin Wolf wrote: > Am 28.03.2019 um 08:21 hat Vladimir Sementsov-Ogievskiy geschrieben: >> bdrv_replace_child() calls bdrv_check_perm() with error_abort on >> loosening permissions. However file-locking operations may fail even >> in this case, for example on NFS. And this leads

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-28 Thread Kevin Wolf
Am 28.03.2019 um 08:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > bdrv_replace_child() calls bdrv_check_perm() with error_abort on > loosening permissions. However file-locking operations may fail even > in this case, for example on NFS. And this leads to Qemu crash. > > Let's ignore such err

Re: [Qemu-devel] [PATCH v2] block/file-posix: ignore fail on unlock bytes

2019-03-28 Thread Eric Blake
On 3/28/19 2:21 AM, Vladimir Sementsov-Ogievskiy wrote: > bdrv_replace_child() calls bdrv_check_perm() with error_abort on > loosening permissions. However file-locking operations may fail even > in this case, for example on NFS. And this leads to Qemu crash. > > Let's ignore such errors, as we do