Re: [Qemu-devel] [PATCH v2] Fix confusing argument names in some common functions

2016-07-12 Thread Peter Maydell
On 14 June 2016 at 13:26, Sergey Sorokin wrote: > There are functions tlb_fill(), cpu_unaligned_access() and > do_unaligned_access() that are called with access type and mmu index > arguments. But these arguments are named 'is_write' and 'is_user' in their > declarations. The patches fix the argum

Re: [Qemu-devel] [PATCH v2] Fix confusing argument names in some common functions

2016-07-11 Thread Sergey Sorokin
11.07.2016, 05:18, "David Gibson" : > I'm afraid your mailer has turned this into an unreadable HTML mess. It was just a ping. http://patchwork.ozlabs.org/patch/635235/

Re: [Qemu-devel] [PATCH v2] Fix confusing argument names in some common functions

2016-07-10 Thread David Gibson
I'm afraid your mailer has turned this into an unreadable HTML mess. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dg

Re: [Qemu-devel] [PATCH v2] Fix confusing argument names in some common functions

2016-07-08 Thread Sergey Sorokin
 14.06.2016, 15:26, "Sergey Sorokin" : There are functions tlb_fill(), cpu_unaligned_access() and do_unaligned_access() that are called with access type and mmu index arguments. But these arguments are named 'is_write' and 'is_user' in their declarations. The patch

Re: [Qemu-devel] [PATCH v2] Fix confusing argument names in some common functions

2016-06-15 Thread David Gibson
On Wed, Jun 15, 2016 at 01:45:58PM +0300, Sergey Sorokin wrote: > 15.06.2016, 06:03, "David Gibson" : > > On Tue, Jun 14, 2016 at 03:26:17PM +0300, Sergey Sorokin wrote: > >>  There are functions tlb_fill(), cpu_unaligned_access() and > >>  do_unaligned_access() that are called with access type and

Re: [Qemu-devel] [PATCH v2] Fix confusing argument names in some common functions

2016-06-15 Thread Sergey Sorokin
15.06.2016, 06:03, "David Gibson" : > On Tue, Jun 14, 2016 at 03:26:17PM +0300, Sergey Sorokin wrote: >>  There are functions tlb_fill(), cpu_unaligned_access() and >>  do_unaligned_access() that are called with access type and mmu index >>  arguments. But these arguments are named 'is_write' and '

Re: [Qemu-devel] [PATCH v2] Fix confusing argument names in some common functions

2016-06-14 Thread David Gibson
On Tue, Jun 14, 2016 at 03:26:17PM +0300, Sergey Sorokin wrote: > There are functions tlb_fill(), cpu_unaligned_access() and > do_unaligned_access() that are called with access type and mmu index > arguments. But these arguments are named 'is_write' and 'is_user' in their > declarations. The patche

Re: [Qemu-devel] [PATCH v2] Fix confusing argument names in some common functions

2016-06-14 Thread Eduardo Habkost
On Tue, Jun 14, 2016 at 03:26:17PM +0300, Sergey Sorokin wrote: > There are functions tlb_fill(), cpu_unaligned_access() and > do_unaligned_access() that are called with access type and mmu index > arguments. But these arguments are named 'is_write' and 'is_user' in their > declarations. The patche