Re: [Qemu-devel] [PATCH v12 35/36] qapi: Simplify visits of optional fields

2015-11-18 Thread Eric Blake
On 11/18/2015 11:54 AM, Markus Armbruster wrote: > Eric Blake writes: > >> None of the visitor callbacks would set an error when testing >> if an optional field was present; make this part of the interface >> contract by eliminating the errp argument. >> >> The resulting generated code has a nice

Re: [Qemu-devel] [PATCH v12 35/36] qapi: Simplify visits of optional fields

2015-11-18 Thread Markus Armbruster
Eric Blake writes: > None of the visitor callbacks would set an error when testing > if an optional field was present; make this part of the interface > contract by eliminating the errp argument. > > The resulting generated code has a nice diff: > > |-visit_optional(v, &has_fdset_id, "fdset-i