Re: [Qemu-devel] [PATCH v10 3/4] block: Add replaces argument to drive-mirror

2014-06-27 Thread Benoît Canet
The Friday 27 Jun 2014 à 15:37:00 (+0200), Kevin Wolf wrote : > Am 27.06.2014 um 14:53 hat Benoît Canet geschrieben: > > The Friday 27 Jun 2014 à 13:57:02 (+0200), Kevin Wolf wrote : > > > Am 16.06.2014 um 12:00 hat Benoît Canet geschrieben: > > > > drive-mirror will bdrv_swap the new BDS named nod

Re: [Qemu-devel] [PATCH v10 3/4] block: Add replaces argument to drive-mirror

2014-06-27 Thread Kevin Wolf
Am 27.06.2014 um 14:53 hat Benoît Canet geschrieben: > The Friday 27 Jun 2014 à 13:57:02 (+0200), Kevin Wolf wrote : > > Am 16.06.2014 um 12:00 hat Benoît Canet geschrieben: > > > drive-mirror will bdrv_swap the new BDS named node-name with the one > > > pointed by replaces when the mirroring is fi

Re: [Qemu-devel] [PATCH v10 3/4] block: Add replaces argument to drive-mirror

2014-06-27 Thread Benoît Canet
The Friday 27 Jun 2014 à 13:57:02 (+0200), Kevin Wolf wrote : > Am 16.06.2014 um 12:00 hat Benoît Canet geschrieben: > > drive-mirror will bdrv_swap the new BDS named node-name with the one > > pointed by replaces when the mirroring is finished. > > > > Signed-off-by: Benoit Canet > > Reviewed-by

Re: [Qemu-devel] [PATCH v10 3/4] block: Add replaces argument to drive-mirror

2014-06-27 Thread Kevin Wolf
Am 16.06.2014 um 12:00 hat Benoît Canet geschrieben: > drive-mirror will bdrv_swap the new BDS named node-name with the one > pointed by replaces when the mirroring is finished. > > Signed-off-by: Benoit Canet > Reviewed-by: Max Reitz > --- > block.c | 17 ++ > blo

Re: [Qemu-devel] [PATCH v10 3/4] block: Add replaces argument to drive-mirror

2014-06-27 Thread Benoît Canet
The Friday 27 Jun 2014 à 13:57:02 (+0200), Kevin Wolf wrote : > Am 16.06.2014 um 12:00 hat Benoît Canet geschrieben: > > drive-mirror will bdrv_swap the new BDS named node-name with the one > > pointed by replaces when the mirroring is finished. > > > > Signed-off-by: Benoit Canet > > Reviewed-by

Re: [Qemu-devel] [PATCH v10 3/4] block: Add replaces argument to drive-mirror

2014-06-19 Thread Stefan Hajnoczi
On Mon, Jun 16, 2014 at 12:00:56PM +0200, Benoît Canet wrote: > +BlockDriverState *check_to_replace_node(const char *node_name, Error **errp) > +{ > +BlockDriverState *to_replace_bs = bdrv_find_node(node_name); > +if (!to_replace_bs) { > +error_setg(errp, "Node name '%s' not found",