Re: [Qemu-devel] [PATCH v1 04/11] s390x: get rid of s390-virtio.c

2017-08-31 Thread David Hildenbrand
>> +return 0; >> +} >> + >> + > > Nit: One empty line should be enough here. > > Reviewed-by: Thomas Huth > Indeed, thanks! -- Thanks, David

Re: [Qemu-devel] [PATCH v1 04/11] s390x: get rid of s390-virtio.c

2017-08-31 Thread David Hildenbrand
On 30.08.2017 19:05, David Hildenbrand wrote: > It is a leftover from the days where we had still the !ccw virtio > machine. As this one is long gone, let's move everything to > s390-virtio-ccw.c. > > Cornelia Huck I will add the missing Suggested-by: :) > Signed-off-by: David Hildenbrand > --

Re: [Qemu-devel] [PATCH v1 04/11] s390x: get rid of s390-virtio.c

2017-08-31 Thread Christian Borntraeger
I have not reviewed this, but the whole idea is Acked-by: Christian Borntraeger On 08/30/2017 07:05 PM, David Hildenbrand wrote: > It is a leftover from the days where we had still the !ccw virtio > machine. As this one is long gone, let's move everything to > s390-virtio-ccw.c. > > Cornelia Hu

Re: [Qemu-devel] [PATCH v1 04/11] s390x: get rid of s390-virtio.c

2017-08-31 Thread Thomas Huth
On 30.08.2017 19:05, David Hildenbrand wrote: > It is a leftover from the days where we had still the !ccw virtio > machine. As this one is long gone, let's move everything to > s390-virtio-ccw.c. > > Cornelia Huck > Signed-off-by: David Hildenbrand > --- [...] > diff --git a/hw/s390x/s390-virti